From 2ef9bcfd118f263c06abfe2c04fe79a530ebe163 Mon Sep 17 00:00:00 2001 From: Roberto Ierusalimschy <roberto@inf.puc-rio.br> Date: Tue, 9 Jul 2013 15:31:01 -0300 Subject: avoid undefined shift of LUA_NBITS in rotate operation --- lbitlib.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lbitlib.c b/lbitlib.c index a76307b6..76d5358e 100644 --- a/lbitlib.c +++ b/lbitlib.c @@ -1,5 +1,5 @@ /* -** $Id: lbitlib.c,v 1.20 2013/06/21 17:27:24 roberto Exp roberto $ +** $Id: lbitlib.c,v 1.21 2013/07/09 17:49:50 roberto Exp roberto $ ** Standard library for bitwise operations ** See Copyright Notice in lua.h */ @@ -128,7 +128,8 @@ static int b_rot (lua_State *L, int i) { lua_Unsigned r = luaL_checkunsigned(L, 1); i &= (LUA_NBITS - 1); /* i = i % NBITS */ r = trim(r); - r = (r << i) | (r >> (LUA_NBITS - i)); + if (i != 0) /* avoid undefined shift of LUA_NBITS when i == 0 */ + r = (r << i) | (r >> (LUA_NBITS - i)); lua_pushunsigned(L, trim(r)); return 1; } -- cgit v1.2.3-55-g6feb