From e8c779736f3029df353038352c14c8ab63728811 Mon Sep 17 00:00:00 2001 From: Roberto Ierusalimschy Date: Thu, 1 Nov 2018 13:21:00 -0300 Subject: Removed internal cache for closures The mechanism of "caching the last closure created for a prototype to try to reuse it the next time a closure for that prototype is created" was removed. There are several reasons: - It is hard to find a natural example where this cache has a measurable impact on performance. - Programmers already perceive closure creation as something slow, so they tend to avoid it inside hot paths. (Any case where the cache could reuse a closure can be rewritten predefining the closure in some variable and using that variable.) - The implementation was somewhat complex, due to a bad interaction with the generational collector. (Typically, new closures are new, while prototypes are old. So, the cache breaks the invariant that old objects should not point to new ones.) --- lfunc.c | 2 -- 1 file changed, 2 deletions(-) (limited to 'lfunc.c') diff --git a/lfunc.c b/lfunc.c index 15874f88..aa6ce58f 100644 --- a/lfunc.c +++ b/lfunc.c @@ -219,8 +219,6 @@ Proto *luaF_newproto (lua_State *L) { f->p = NULL; f->sizep = 0; f->code = NULL; - f->cache = NULL; - f->cachemiss = 0; f->sizecode = 0; f->lineinfo = NULL; f->sizelineinfo = 0; -- cgit v1.2.3-55-g6feb