A mirror of https://github.com/luarocks/luarocks.git https://git.lua4.win/luarocks/atom?h=copilot%2Ffix-luadir-printing-issue 2026-07-18T13:02:20+00:00 2026-07-18T13:02:20+00:00 Thijs Schreijer thijs@thijsschreijer.nl 2026-07-16T20:17:44+00:00 urn:sha1:abb0c4b7ee59ec6e3a7d9ed14db49550bd28b953 2026-07-16T20:47:50+00:00 Hugo Levy-Falk hugo@klafyvel.me 2026-07-14T05:54:22+00:00 urn:sha1:9a92fe42071a0183497032c3a7c8a7b7c6015f52 2026-07-12T01:13:55+00:00 Tobiasz Laskowski tobil4sk@outlook.com 2026-02-15T14:53:13+00:00 urn:sha1:0e90c184ef44dae80be747983e27c6940fbea3b9 See: #1257 On most platforms LUA_LIBDIR is empty, so you get: Warning: unmatched variable LUA_LIBDIR And the resulting empty -L flag in the example can cause issues like: ld: warning: search path '-lpthread' not found It's also not sufficient to pass the -L flag, you also have to provide the actual library to link. I've updated the example to only set LUA_LIBDIR for windows where it is used by default. However, as noted in it is possible to do: luarocks config link_lua_explicitly true It would be better to respect this setting rather than hard-coding windows only, but I'm not sure the best way to check that config in the rockspec, I wonder if anyone else has any suggestions? [docs] Use implicit rules in example makefile See: https://www.gnu.org/software/make/manual/html_node/Catalogue-of-Rules.html#index-C_002c-rule-to-compile https://www.gnu.org/software/make/manual/html_node/Catalogue-of-Rules.html#index-linking_002c-predefined-rule-for https://www.gnu.org/software/make/manual/html_node/Implicit-Variables.html#index-CPPFLAGS https://www.gnu.org/software/make/manual/html_node/Implicit-Variables.html#index-LDFLAGS [docs] Fix LUA_LIBDIR handling in makefile example The example setup given here gives this warning on most systems: ``` Warning: unmatched variable LUA_LIBDIR ``` Also, you get an empty `-L` flag, which one some compilers will eat the following flag, causing issues, e.g. ``` ld: warning: search path '-lpthread' not found ``` This is because most environments do not require explicit linking of LUALIB, so it LUA_LIBDIR not set. This patch fixes the sample by only setting `LUA_LIBDIR` when it is actually needed, i.e. on windows. [docs] Fix example makefile for windows On windows, LUALIB is set to e.g. `lua51.dll`, which is the full name and does not work with `-llua51.dll`. Passing the full path here allows it to be linked properly. Another option is `-l:$(LUALIB)` to specify the full file name, but some linkers do not support that syntax. [docs] Fix broken formatting due to unescaped $ [docs] Highlight makefile syntax [docs] Use consistent whitespace Fixes markdown warnings about hard tabs 2026-07-11T22:17:17+00:00 Christian Clauss cclauss@me.com 2026-06-27T20:26:21+00:00 urn:sha1:b950459b4aff01a521b519f79bfd0a1eb3066418 2026-01-28T15:05:30+00:00 congusbongus congusbongus@gmail.com 2025-11-08T00:39:26+00:00 urn:sha1:2dc04f0531dac3b968ab5e8847c43e19db7c3efd This allows copy pasting the commands easily 2026-01-28T15:04:16+00:00 Marc Jakobi marc@jakobi.dev 2026-01-08T10:14:37+00:00 urn:sha1:834412707161dabd548a2dbb0cfcf76050364214 2025-11-17T21:13:39+00:00 Daniel Jour musteresel@gmail.com 2025-11-07T09:56:58+00:00 urn:sha1:498a26568eb0ea6dd585bf9f87558e4a0e48387a 2025-06-05T22:25:45+00:00 Hisham Muhammad hisham@gobolinux.org 2025-06-05T22:21:25+00:00 urn:sha1:ebe1327df3e84f3d6fe5f546b442ececfb9ea86b 2025-05-19T14:30:51+00:00 Renato Maia maia.renato@gmail.com 2025-04-27T20:03:33+00:00 urn:sha1:3b7bf479568790a8b04772a36c1b3e712fed4579 Rockspecs can access the directory of its dependencies using variables in the format 'foo_ROCKDIR' where 'foo' is the name of a dependency. This is used to be able to access files of the rock like 'conf', 'docs' and more. 2025-05-19T14:30:51+00:00 Renato Maia maia.renato@gmail.com 2025-04-21T14:16:38+00:00 urn:sha1:4d7b546602b906f924ac91a01276cd3b2569ca9f