Merge branch 'master' into luarocks-3

17 files changed, 136 insertions, 82 deletions

diff --git a/configure b/configure
index 3636aed3..ae2696d2 100755
--- a/configure
+++ b/configure
@@ -229,15 +229,17 @@ detect_lua_version() {
    detected_lua=`$1 -e 'print(_VERSION:match(" (5%.[123])$"))' 2> /dev/null`
    if [ "$detected_lua" != "nil" ]
    then
-      echo "Lua version detected: $detected_lua"
       if [ "$LUA_VERSION_SET" != "yes" ]
       then
+         echo "Lua version detected: $detected_lua"
          LUA_VERSION=$detected_lua
-      elif [ "$LUA_VERSION" != "$detected_lua" ]
+         return 0
+      elif [ "$LUA_VERSION" = "$detected_lua" ]
       then
-         die "This clashes with the value of --lua-version. Please check your configuration."
+         return 0
       fi
    fi
+   return 1
 }
 
 search_interpreter() {
@@ -247,23 +249,35 @@ search_interpreter() {
       find_lua="$LUA_BINDIR"
    elif [ "$LUA_DIR_SET" = "yes" ]
    then
-      if [ -f "$LUA_DIR/bin/lua$suffix" ]
+      LUA_BINDIR="$LUA_DIR/bin"
+      if [ -f "$LUA_BINDIR/lua$suffix" ]
       then
-         find_lua="$LUA_DIR/bin"
+         find_lua="$LUA_BINDIR"
       fi
    else
       find_lua=`find_program lua$suffix`
    fi
    if [ -n "$find_lua" -a -x "$find_lua/lua$suffix" ]
    then
-      echo "Lua interpreter found: $find_lua/lua$suffix..."
-      LUA_SUFFIX=$suffix
-      detect_lua_version "$find_lua/lua$LUA_SUFFIX"
-      return 0
+      if detect_lua_version "$find_lua/lua$suffix"
+      then
+         echo "Lua interpreter found: $find_lua/lua$suffix..."
+         if [ "$LUA_BINDIR_SET" != "yes" ]
+         then
+            LUA_BINDIR="$find_lua"
+         fi
+         if [ "$LUA_DIR_SET" != "yes" ]
+         then
+            LUA_DIR=`dirname "$find_lua"`
+         fi
+         LUA_SUFFIX="$suffix"
+         return 0
+      fi
    fi
    return 1
 }
 
+lua_interp_found=no
 if [ "$LUA_SUFFIX_SET" != "yes" ]
 then
    if [ "$LUA_VERSION_SET" = "yes" -a "$LUA_VERSION" = "5.1" ]
@@ -278,7 +292,6 @@ then
    else
       suffixes="5.3 53 -5.3 -53 5.2 52 -5.2 -52 5.1 51 -5.1 -51"
    fi
-   lua_interp_found=no
    for suffix in "" `echo $suffixes`
    do
       search_interpreter "$suffix" && {
@@ -286,23 +299,28 @@ then
          break
       }
    done
+else
+   search_interpreter "$LUA_SUFFIX" && {
+      lua_interp_found=yes
+   }
 fi
 
-if [ "$LUA_DIR_SET" != "yes" ]
+if [ "$lua_interp_found" != "yes" ]
 then
-   if [ -z "$find_lua" ]
-   then
-      echo_n "Looking for Lua... "
-      find_lua=`find_program lua$LUA_SUFFIX`
-   fi
+   [ "$LUA_VERSION_SET" ] && { interp="Lua $LUA_VERSION" ;} || { interp="Lua" ;}
+   [ "$LUA_DIR_SET" -o "$LUA_BINDIR_SET" ] && { where="$LUA_BINDIR" ;} || { interp="\$PATH" ;}
+   echo "$interp interpreter not found in $where"
+   die "You may want to use the flags --with-lua, --with-lua-bin and/or --lua-suffix. See --help."
+fi
 
-   if [ -n "$find_lua" ]
+if [ "$LUA_VERSION_SET" = "yes" ]
+then
+   echo_n "Checking if $LUA_BINDIR/lua$LUA_SUFFIX is Lua version $LUA_VERSION... "
+   if detect_lua_version "$LUA_BINDIR/lua$LUA_SUFFIX"
    then
-      LUA_DIR=`dirname $find_lua`
-      LUA_BINDIR="$find_lua"
-      echo "lua$LUA_SUFFIX found in \$PATH: $find_lua"
+      echo "yes"
    else
-      echo "lua$LUA_SUFFIX not found in \$PATH."
+      echo "no"
       die "You may want to use the flags --with-lua, --with-lua-bin and/or --lua-suffix. See --help."
    fi
 fi
@@ -317,23 +335,6 @@ then
    LUA_LIBDIR="$LUA_DIR/lib"
 fi
 
-if [ "$LUA_DIR_SET" = "yes" -a "$LUA_BINDIR_SET" != "yes" ]
-then
-   LUA_BINDIR="$LUA_DIR/bin"
-fi
-
-if [ "$lua_interp_found" != "yes" ]
-then
-   echo_n "Checking Lua interpreter... "
-   if [ -x "$LUA_BINDIR/lua$LUA_SUFFIX" ]
-   then
-      echo "lua$LUA_SUFFIX found in $LUA_BINDIR"
-   else
-      echo "lua$LUA_SUFFIX not found (looked in $LUA_BINDIR)"
-      die "You may want to use the flag --with-lua or --with-lua-bin. See --help."
-   fi
-fi
-
 echo_n "Checking Lua includes... "
 lua_h="$LUA_INCDIR/lua.h"
 if [ -f "$lua_h" ]
@@ -360,6 +361,18 @@ else
    fi
 fi
 
+echo_n "Checking if Lua header version matches that of the interpreter... "
+header_version=$(sed -n 's/.*LUA_VERSION_NUM.*5.\(.\).*/5.\1/p' "$lua_h")
+if [ "$header_version" = "$LUA_VERSION" ]
+then
+   echo "yes"
+else
+   echo "no"
+   echo "lua.h version mismatch (interpreter: $LUA_VERSION; lua.h: $header_version)."
+   die "You may want to use the flag --with-lua or --with-lua-include. See --help."
+fi
+
+
 if [ "$LUAROCKS_DOWNLOADER_SET" != "yes" ]
 then
    find_helper "a downloader helper program" curl wget fetch
diff --git a/spec/remove_spec.lua b/spec/remove_spec.lua
index 3d321e30..03b3681e 100644
--- a/spec/remove_spec.lua
+++ b/spec/remove_spec.lua
@@ -35,12 +35,19 @@ describe("LuaRocks remove tests #blackbox #b_remove", function()
          assert.is_false(run.luarocks_bool("remove luacov --deps-mode"))
       end)
 
-      it("LuaRocks remove builded abelhas", function()
+      it("LuaRocks remove built abelhas", function()
          assert.is_true(run.luarocks_bool("build abelhas 1.0"))
          assert.is.truthy(lfs.attributes(testing_paths.testing_sys_tree .. "/lib/luarocks/rocks/abelhas"))
          assert.is_true(run.luarocks_bool("remove abelhas 1.0"))
          assert.is.falsy(lfs.attributes(testing_paths.testing_sys_tree .. "/lib/luarocks/rocks/abelhas"))
       end)
+
+      it("LuaRocks remove built abelhas with uppercase name", function()
+         assert.is_true(run.luarocks_bool("build abelhas 1.0"))
+         assert.is.truthy(lfs.attributes(testing_paths.testing_sys_tree .. "/lib/luarocks/rocks/abelhas"))
+         assert.is_true(run.luarocks_bool("remove Abelhas 1.0"))
+         assert.is.falsy(lfs.attributes(testing_paths.testing_sys_tree .. "/lib/luarocks/rocks/abelhas"))
+      end)
    end)
 
    describe("LuaRocks remove more complex tests", function()
diff --git a/spec/show_spec.lua b/spec/show_spec.lua
index b95ea818..0b046de0 100644
--- a/spec/show_spec.lua
+++ b/spec/show_spec.lua
@@ -22,6 +22,11 @@ describe("LuaRocks show tests #blackbox #b_show", function()
          local output = run.luarocks("show luacov")
          assert.is.truthy(output:match("LuaCov"))
       end)
+
+      it("LuaRocks show luacov with uppercase name", function()
+         local output = run.luarocks("show LuaCov")
+         assert.is.truthy(output:match("LuaCov"))
+      end)
       
       it("LuaRocks show modules of luacov", function()
          local output = run.luarocks("show --modules luacov")
diff --git a/src/luarocks/build.lua b/src/luarocks/build.lua
index 3601dc9b..f3b054d2 100644
--- a/src/luarocks/build.lua
+++ b/src/luarocks/build.lua
@@ -226,7 +226,7 @@ function build.build_rockspec(rockspec_file, need_to_fetch, minimal_mode, deps_m
    end
 
    if not minimal_mode then
-      local _, source_dir
+      local source_dir
       if need_to_fetch then
          ok, source_dir, errcode = fetch.fetch_sources(rockspec, true)
          if not ok then
diff --git a/src/luarocks/build/builtin.lua b/src/luarocks/build/builtin.lua
index 3a4beb17..db6f8bc4 100644
--- a/src/luarocks/build/builtin.lua
+++ b/src/luarocks/build/builtin.lua
@@ -175,7 +175,7 @@ function builtin.run(rockspec)
             add_flags(extras, "-Wl,-rpath,%s:", libdirs)
          end
          add_flags(extras, "-l%s", libraries)
-         if cfg.is_platform("cygwin") then
+         if cfg.link_lua_explicitly then
             add_flags(extras, "-l%s", {"lua"})
          end
          return execute(variables.LD.." "..variables.LIBFLAG, "-o", library, "-L"..variables.LUA_LIBDIR, unpack(extras))
diff --git a/src/luarocks/command_line.lua b/src/luarocks/command_line.lua
index f7f6ccb6..96891b75 100644
--- a/src/luarocks/command_line.lua
+++ b/src/luarocks/command_line.lua
@@ -2,7 +2,6 @@
 --- Functions for command-line scripts.
 local command_line = {}
 
-local pack = function(...) return {...}, select("#", ...) end
 local unpack = unpack or table.unpack
 
 local util = require("luarocks.util")
diff --git a/src/luarocks/core/cfg.lua b/src/luarocks/core/cfg.lua
index 17f76d14..de8b9281 100644
--- a/src/luarocks/core/cfg.lua
+++ b/src/luarocks/core/cfg.lua
@@ -131,24 +131,27 @@ else
    -- Fall back to Unix in unknown systems.
 end
 
--- Set order for platform overrides
+-- Set order for platform overrides.
+-- More general platform identifiers should be listed first,
+-- more specific ones later.
 local platform_order = {
    -- Unixes
-   unix = 1,
-   bsd = 2, 
-   solaris = 3,
-   netbsd = 4,
-   openbsd = 5,
-   freebsd = 6,
-   linux = 7,
-   macosx = 8,
-   cygwin = 9,
-   msys = 10,
-   haiku = 11,
+   "unix",
+   "bsd",
+   "solaris",
+   "netbsd",
+   "openbsd",
+   "freebsd",
+   "linux",
+   "macosx",
+   "cygwin",
+   "msys",
+   "haiku",
    -- Windows
-   win32 = 12,
-   mingw32 = 13,
-   windows = 14 }
+   "win32",
+   "mingw32",
+   "windows",
+}
 
 -- Path configuration:
 local sys_config_file, home_config_file
@@ -274,26 +277,50 @@ if not next(cfg.rocks_trees) then
    end
 end
 
-
 -- update platforms list; keyed -> array
 do
-   local lst = {} -- use temp array to not confuse `pairs` in loop
-   for plat in pairs(cfg.platforms) do 
-      if cfg.platforms[plat] then  -- entries set to 'false' skipped
-         if not platform_order[plat] then
-            local pl = ""
-            for k,_ in pairs(platform_order) do pl = pl .. ", " .. k end
-            io.stderr:write("Bad platform given; "..tostring(plat)..". Valid entries are: "..pl:sub(3,-1) ..".\n")
-            os.exit(cfg.errorcodes.CONFIGFILE)
+   -- if explicitly given by user,
+   if cfg.platforms[1] then
+      local is_windows = cfg.platforms.windows
+      -- Clear auto-detected values
+      for k, _ in pairs(cfg.platforms) do
+         if type(k) == "string" then
+            cfg.platforms[k] = nil
+         end
+      end
+      -- and set the ones given by the user.
+      for _, plat in ipairs(cfg.platforms) do
+         cfg.platforms[plat] = true
+      end
+      -- If no major platform family was set by the user,
+      if not (cfg.platforms.unix or cfg.platforms.windows) then
+         -- set some fallback defaults in case the user provides an incomplete configuration.
+         -- LuaRocks expects a set of defaults to be available.
+         -- This is used for setting defaults here only; the platform overrides
+         -- will use only the user's list.
+         if is_windows then
+            cfg.platforms.windows = true
+            table.insert(cfg.platforms, "windows")
+         else
+            cfg.platforms.unix = true
+            table.insert(cfg.platforms, "unix")
+         end
+      end
+   else
+      -- Sort detected platform defaults
+      local order = {}
+      for i, v in ipairs(platform_order) do
+         order[v] = i
+      end
+      local entries = {}
+      for k, v in pairs(cfg.platforms) do
+         if type(k) == "string" and v == true then
+            table.insert(entries, k)
          end
-         table.insert(lst, plat)
-      else
-         cfg.platforms[plat] = nil
       end
+      table.sort(entries, function(a, b) return order[a] < order[b] end)
+      util.deep_merge(cfg.platforms, entries)
    end
-   -- platform overrides depent on the order, so set priorities
-   table.sort(lst, function(key1, key2) return platform_order[key1] < platform_order[key2] end)
-   util.deep_merge(cfg.platforms, lst)
 end
 
 -- Configure defaults:
@@ -315,6 +342,7 @@ local defaults = {
    arch = "unknown",
    lib_extension = "unknown",
    obj_extension = "unknown",
+   link_lua_explicitly = false,
 
    rocks_servers = {
       {
@@ -536,6 +564,7 @@ if cfg.platforms.cygwin then
    defaults.variables.CC = "echo -llua | xargs gcc"
    defaults.variables.LD = "echo -llua | xargs gcc"
    defaults.variables.LIBFLAG = "-shared"
+   defaults.link_lua_explicitly = true
 end
 
 if cfg.platforms.msys then
diff --git a/src/luarocks/doc.lua b/src/luarocks/doc.lua
index 63c4c4e3..5d521276 100644
--- a/src/luarocks/doc.lua
+++ b/src/luarocks/doc.lua
@@ -61,6 +61,8 @@ function doc.command(flags, name, version)
       return nil, "Argument missing. "..util.see_help("doc")
    end
 
+   name = name:lower()
+
    local iname, iversion, repo = search.pick_installed_rock(name, version, flags["tree"])
    if not iname then
       util.printout(name..(version and " "..version or "").." is not installed. Looking for it in the rocks servers...")
diff --git a/src/luarocks/download.lua b/src/luarocks/download.lua
index c81958de..557d1b65 100644
--- a/src/luarocks/download.lua
+++ b/src/luarocks/download.lua
@@ -100,7 +100,7 @@ function download.command(flags, name, version)
       arch = flags["arch"]
    end
    
-   local dl, err = download.download(arch, name, version, flags["all"])
+   local dl, err = download.download(arch, name:lower(), version, flags["all"])
    return dl and true, err
 end
 
diff --git a/src/luarocks/lint.lua b/src/luarocks/lint.lua
index 742f1736..c9ea45ea 100644
--- a/src/luarocks/lint.lua
+++ b/src/luarocks/lint.lua
@@ -24,7 +24,7 @@ function lint.command(flags, input)
    local filename = input
    if not input:match(".rockspec$") then
       local err
-      filename, err = download.download("rockspec", input)
+      filename, err = download.download("rockspec", input:lower())
       if not filename then
          return nil, err
       end
diff --git a/src/luarocks/manif.lua b/src/luarocks/manif.lua
index 40657fdf..8277b3a5 100644
--- a/src/luarocks/manif.lua
+++ b/src/luarocks/manif.lua
@@ -32,6 +32,7 @@ function manif.load_rock_manifest(name, version, root)
    return rock_manifest.rock_manifest
 end
 
+
 local function fetch_manifest_from(repo_url, filename)
    local url = dir.path(repo_url, filename)
    local name = repo_url:gsub("[/:]","_")
diff --git a/src/luarocks/new_version.lua b/src/luarocks/new_version.lua
index 000b459b..b13dbb97 100644
--- a/src/luarocks/new_version.lua
+++ b/src/luarocks/new_version.lua
@@ -140,7 +140,7 @@ function new_version.command(flags, input, version, url)
          return nil, err
       end
    else
-      filename, err = download.download("rockspec", input)
+      filename, err = download.download("rockspec", input:lower())
       if not filename then
          return nil, err
       end
diff --git a/src/luarocks/pack.lua b/src/luarocks/pack.lua
index 49c68e85..655cbf37 100644
--- a/src/luarocks/pack.lua
+++ b/src/luarocks/pack.lua
@@ -180,7 +180,7 @@ function pack.command(flags, arg, version)
    if arg:match(".*%.rockspec") then
       file, err = pack.pack_source_rock(arg)
    else
-      file, err = do_pack_binary_rock(arg, version, flags["tree"])
+      file, err = do_pack_binary_rock(arg:lower(), version, flags["tree"])
    end
    if err then
       return nil, err
diff --git a/src/luarocks/path_cmd.lua b/src/luarocks/path_cmd.lua
index 1f5bb07f..627d97cf 100644
--- a/src/luarocks/path_cmd.lua
+++ b/src/luarocks/path_cmd.lua
@@ -4,8 +4,8 @@
 local path_cmd = {}
 
 local util = require("luarocks.util")
-local deps = require("luarocks.deps")
 local cfg = require("luarocks.core.cfg")
+local cfg = require("luarocks.cfg")
 
 path_cmd.help_summary = "Return the currently configured package path."
 path_cmd.help_arguments = ""
@@ -34,8 +34,6 @@ And on Windows:
 --- Driver function for "path" command.
 -- @return boolean This function always succeeds.
 function path_cmd.command(flags)
-   local deps_mode = deps.get_deps_mode(flags)
-   
    local lr_path, lr_cpath, lr_bin = cfg.package_paths(flags["tree"])
    local path_sep = cfg.export_path_separator
 
diff --git a/src/luarocks/remove.lua b/src/luarocks/remove.lua
index 008d2616..e7f37604 100644
--- a/src/luarocks/remove.lua
+++ b/src/luarocks/remove.lua
@@ -10,7 +10,6 @@ local repos = require("luarocks.repos")
 local path = require("luarocks.path")
 local util = require("luarocks.util")
 local cfg = require("luarocks.core.cfg")
-local writer = require("luarocks.manif.writer")
 local fs = require("luarocks.fs")
 
 remove.help_summary = "Uninstall a rock."
@@ -154,6 +153,7 @@ function remove.command(flags, name, version)
    end
 
    local results = {}
+   name = name:lower()
    search.manifest_search(results, cfg.rocks_dir, search.make_query(name, version))
    if not results[name] then
       return nil, "Could not find rock '"..name..(version and " "..version or "").."' in "..path.rocks_tree_to_string(cfg.root_dir)
diff --git a/src/luarocks/show.lua b/src/luarocks/show.lua
index 53d8ffa5..1ff81e08 100644
--- a/src/luarocks/show.lua
+++ b/src/luarocks/show.lua
@@ -76,7 +76,7 @@ function show.command(flags, name, version)
    end
    
    local repo, repo_url
-   name, version, repo, repo_url = search.pick_installed_rock(name, version, flags["tree"])
+   name, version, repo, repo_url = search.pick_installed_rock(name:lower(), version, flags["tree"])
    if not name then
       return nil, version
    end
diff --git a/src/luarocks/unpack.lua b/src/luarocks/unpack.lua
index af3398ab..c50701b0 100644
--- a/src/luarocks/unpack.lua
+++ b/src/luarocks/unpack.lua
@@ -157,7 +157,7 @@ function unpack.command(flags, name, version)
       return run_unpacker(name, flags["force"])
    else
       local search = require("luarocks.search")
-      return search.act_on_src_or_rockspec(run_unpacker, name, version)
+      return search.act_on_src_or_rockspec(run_unpacker, name:lower(), version)
    end
 end