General refactor introducing Rockspec and Build.Opts objects

Adds a Rockspec object responsible for constructing all Rockspec
tables in the manner of the Queries and Results objects, and
a type-checked Build.Opts tables for build options, since
the number of attributes passed around was getting out of hand.

This allowed a major cleanup in the luarocks.build,
luarocks.fetch and luarocks.cmd.write_rockspec modules.

1 files changed, 0 insertions, 9 deletions

diff --git a/spec/fetch_spec.lua b/spec/fetch_spec.lua
index c02c5736..aa107970 100644
--- a/spec/fetch_spec.lua
+++ b/spec/fetch_spec.lua
@@ -208,15 +208,6 @@ describe("Luarocks fetch test #unit", function()
       end)
    end)
 
-   describe("fetch.url_to_base_dir", function()
-      assert.are.same("v0.3", fetch.url_to_base_dir("https://example.com/hishamhm/lua-compat-5.2/archive/v0.3.zip"))
-      assert.are.same("lua-compat-5.2", fetch.url_to_base_dir("https://example.com/hishamhm/lua-compat-5.2.zip"))
-      assert.are.same("lua-compat-5.2", fetch.url_to_base_dir("https://example.com/hishamhm/lua-compat-5.2.tar.gz"))
-      assert.are.same("lua-compat-5.2", fetch.url_to_base_dir("https://example.com/hishamhm/lua-compat-5.2.tar.bz2"))
-      assert.are.same("parser.moon", fetch.url_to_base_dir("git://example.com/Cirru/parser.moon"))
-      assert.are.same("v0.3", fetch.url_to_base_dir("https://example.com/hishamhm/lua-compat-5.2/archive/v0.3"))
-   end)
-   
    describe("fetch.load_local_rockspec", function()
       it("returns a table representing the rockspec from the given file skipping some checks if the quick argument is enabled", function()
          local rockspec = fetch.load_local_rockspec(testing_paths.fixtures_dir .. "/a_rock-1.0-1.rockspec", true)