dependency pinning: luarocks.lock file and --pin flag

This adds support for pinning dependencies in projects and rocks:

* Adds a new flag called `--pin` which creates a `luarocks.lock`
  when building a rock with `luarocks build` or `luarocks make`.
  This lock file contains the exact version numbers of every
  direct or indirect dependency of the rock (in other words,
  it is the transitive closure of the dependencies.)
  For `make`, the `luarocks.lock` file is created in the current
  directory.
  The lock file is also installed as part of the rock in
  its metadata directory alongside its rockspec.
  When using `--pin`, if a lock file already exists, it is
  ignored and overwritten.
* When building a rock with `luarocks make`, if there is a
  `luarocks.lock` file in the current directory, the exact
  versions specified there will be used for resolving dependencies.
* When building a rock with `luarocks build`, if there is a
  `luarocks.lock` file in root of its sources, the exact
  versions specified there will be used for resolving dependencies.
* When installing a `.rock` file with `luarocks install`, if the
  rock contains a `luarocks.lock` file (i.e., if its dependencies
  were pinned with `--pin` when the rock was built), the exact
  versions specified there will be used for resolving dependencies.

1 files changed, 119 insertions, 0 deletions

diff --git a/spec/make_spec.lua b/spec/make_spec.lua
index 5ec99fa7..8baa3561 100644
--- a/spec/make_spec.lua
+++ b/spec/make_spec.lua
@@ -3,6 +3,7 @@ local lfs = require("lfs")
 local run = test_env.run
 local testing_paths = test_env.testing_paths
 local env_variables = test_env.env_variables
+local write_file = test_env.write_file
 
 test_env.unload_luarocks()
 
@@ -125,6 +126,124 @@ describe("LuaRocks make tests #integration", function()
       end)
    end)
 
+   it("supports --pin #pinning", function()
+      test_env.run_in_tmp(function(tmpdir)
+         write_file("test-1.0-1.rockspec", [[
+            package = "test"
+            version = "1.0-1"
+            source = {
+               url = "file://]] .. tmpdir:gsub("\\", "/") .. [[/test.lua"
+            }
+            dependencies = {
+               "a_rock 1.0"
+            }
+            build = {
+               type = "builtin", 
+               modules = {
+                  test = "test.lua"
+               }
+            }
+         ]], finally)
+         write_file("test.lua", "return {}", finally)
+
+         assert.is_true(run.luarocks_bool("make --server=" .. testing_paths.fixtures_dir .. "/a_repo --pin --tree=lua_modules"))
+         assert.is.truthy(lfs.attributes("./lua_modules/lib/luarocks/rocks-" .. test_env.lua_version .. "/test/1.0-1/test-1.0-1.rockspec"))
+         assert.is.truthy(lfs.attributes("./lua_modules/lib/luarocks/rocks-" .. test_env.lua_version .. "/a_rock/1.0-1/a_rock-1.0-1.rockspec"))
+         local lockfilename = "./lua_modules/lib/luarocks/rocks-" .. test_env.lua_version .. "/test/1.0-1/luarocks.lock"
+         assert.is.truthy(lfs.attributes(lockfilename))
+         local lockdata = loadfile(lockfilename)()
+         assert.same({
+            dependencies = {
+               ["a_rock"] = "1.0-1",
+               ["lua"] = test_env.lua_version .. "-1",
+            }
+         }, lockdata)
+      end)
+   end)
+
+   it("respects luarocks.lock when present #pinning", function()
+      test_env.run_in_tmp(function(tmpdir)
+         write_file("test-2.0-1.rockspec", [[
+            package = "test"
+            version = "2.0-1"
+            source = {
+               url = "file://]] .. tmpdir:gsub("\\", "/") .. [[/test.lua"
+            }
+            dependencies = {
+               "a_rock >= 0.8"
+            }
+            build = {
+               type = "builtin", 
+               modules = {
+                  test = "test.lua"
+               }
+            }
+         ]], finally)
+         write_file("test.lua", "return {}", finally)
+         write_file("luarocks.lock", [[
+            return {
+               dependencies = {
+                  ["a_rock"] = "1.0-1",
+               }
+            }
+         ]], finally)
+
+         print(run.luarocks("make --server=" .. testing_paths.fixtures_dir .. "/a_repo --tree=lua_modules"))
+         assert.is.truthy(lfs.attributes("./lua_modules/lib/luarocks/rocks-" .. test_env.lua_version .. "/test/2.0-1/test-2.0-1.rockspec"))
+         assert.is.truthy(lfs.attributes("./lua_modules/lib/luarocks/rocks-" .. test_env.lua_version .. "/a_rock/1.0-1/a_rock-1.0-1.rockspec"))
+         local lockfilename = "./lua_modules/lib/luarocks/rocks-" .. test_env.lua_version .. "/test/2.0-1/luarocks.lock"
+         assert.is.truthy(lfs.attributes(lockfilename))
+         local lockdata = loadfile(lockfilename)()
+         assert.same({
+            dependencies = {
+               ["a_rock"] = "1.0-1",
+            }
+         }, lockdata)
+      end)
+   end)
+
+   it("overrides luarocks.lock with --pin #pinning", function()
+      test_env.run_in_tmp(function(tmpdir)
+         write_file("test-2.0-1.rockspec", [[
+            package = "test"
+            version = "2.0-1"
+            source = {
+               url = "file://]] .. tmpdir:gsub("\\", "/") .. [[/test.lua"
+            }
+            dependencies = {
+               "a_rock >= 0.8"
+            }
+            build = {
+               type = "builtin", 
+               modules = {
+                  test = "test.lua"
+               }
+            }
+         ]], finally)
+         write_file("test.lua", "return {}", finally)
+         write_file("luarocks.lock", [[
+            return {
+               dependencies = {
+                  ["a_rock"] = "1.0-1",
+               }
+            }
+         ]], finally)
+
+         print(run.luarocks("make --server=" .. testing_paths.fixtures_dir .. "/a_repo --tree=lua_modules --pin"))
+         assert.is.truthy(lfs.attributes("./lua_modules/lib/luarocks/rocks-" .. test_env.lua_version .. "/test/2.0-1/test-2.0-1.rockspec"))
+         assert.is.truthy(lfs.attributes("./lua_modules/lib/luarocks/rocks-" .. test_env.lua_version .. "/a_rock/2.0-1/a_rock-2.0-1.rockspec"))
+         local lockfilename = "./lua_modules/lib/luarocks/rocks-" .. test_env.lua_version .. "/test/2.0-1/luarocks.lock"
+         assert.is.truthy(lfs.attributes(lockfilename))
+         local lockdata = loadfile(lockfilename)()
+         assert.same({
+            dependencies = {
+               ["a_rock"] = "2.0-1",
+               ["lua"] = test_env.lua_version .. "-1",
+            }
+         }, lockdata)
+      end)
+   end)
+
    describe("#ddt LuaRocks make upgrading rockspecs with double deploy types", function()
       local deploy_lib_dir = testing_paths.testing_sys_tree .. "/lib/lua/"..env_variables.LUA_VERSION
       local deploy_lua_dir = testing_paths.testing_sys_tree .. "/share/lua/"..env_variables.LUA_VERSION