diff options
author | Thijs Schreijer <thijs@thijsschreijer.nl> | 2013-04-12 20:20:11 +0200 |
---|---|---|
committer | Thijs Schreijer <thijs@thijsschreijer.nl> | 2013-04-12 20:20:11 +0200 |
commit | 5576f7a93a1e2eeb268dff0b30f786a086966837 (patch) | |
tree | a97bf2ae2ecab2d8331a0b6fd0310f326f39ea2a /src | |
parent | 9cb1ccaeafb02c48d1aa87e746b1d2716454485f (diff) | |
download | luarocks-5576f7a93a1e2eeb268dff0b30f786a086966837.tar.gz luarocks-5576f7a93a1e2eeb268dff0b30f786a086966837.tar.bz2 luarocks-5576f7a93a1e2eeb268dff0b30f786a086966837.zip |
bug in builtin.lua that caused a previous "ok=false" to be reset in a later stage of building and hence report success even though it had errors.
Diffstat (limited to 'src')
-rw-r--r-- | src/luarocks/build/builtin.lua | 14 |
1 files changed, 8 insertions, 6 deletions
diff --git a/src/luarocks/build/builtin.lua b/src/luarocks/build/builtin.lua index 853b0361..96ce35a6 100644 --- a/src/luarocks/build/builtin.lua +++ b/src/luarocks/build/builtin.lua | |||
@@ -230,12 +230,14 @@ function run(rockspec) | |||
230 | end | 230 | end |
231 | end | 231 | end |
232 | end | 232 | end |
233 | for name, dest in pairs(built_modules) do | 233 | if ok then |
234 | fs.make_dir(dest) | 234 | for name, dest in pairs(built_modules) do |
235 | ok = fs.copy(name, dest) | 235 | fs.make_dir(dest) |
236 | if not ok then | 236 | ok = fs.copy(name, dest) |
237 | err = "Failed installing "..name.." in "..dest | 237 | if not ok then |
238 | break | 238 | err = "Failed installing "..name.." in "..dest |
239 | break | ||
240 | end | ||
239 | end | 241 | end |
240 | end | 242 | end |
241 | if ok then | 243 | if ok then |