From 67ea6328e567fd224e7cd8ed23f55571928d7e1b Mon Sep 17 00:00:00 2001
From: Hisham Muhammad <hisham@gobolinux.org>
Date: Mon, 13 Apr 2020 19:46:28 -0300
Subject: fix regression in dependency matching of luarocks.loader

Regression introduced in
https://github.com/luarocks/luarocks/commit/65c417e0ecda55f44c691df032163a8c08f0b52a

Thanks to @lhemkendreis for the detailed description and suggested
fix, which was applied here!

Added a regression test which exercises dependency matching.

Closes #1175.
---
 spec/loader_spec.lua | 64 ++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 64 insertions(+)

(limited to 'spec')

diff --git a/spec/loader_spec.lua b/spec/loader_spec.lua
index 0f946b72..35179080 100644
--- a/spec/loader_spec.lua
+++ b/spec/loader_spec.lua
@@ -1,5 +1,7 @@
 local test_env = require("spec.util.test_env")
 local run = test_env.run
+local testing_paths = test_env.testing_paths
+local write_file = test_env.write_file
 
 describe("luarocks.loader", function()
    describe("#unit", function()
@@ -7,4 +9,66 @@ describe("luarocks.loader", function()
          assert(run.lua_bool([[-e "require 'luarocks.loader'; print(package.loaded['luarocks.loaded'])"]]))
       end)
    end)
+
+   describe("#integration", function()
+      it("respects version constraints", function()
+         test_env.run_in_tmp(function(tmpdir)
+            write_file("rock_b_01.lua", "print('ROCK B 0.1'); return {}", finally)
+            write_file("rock_b-0.1-1.rockspec", [[
+               package = "rock_b"
+               version = "0.1-1"
+               source = {
+                  url = "file://]] .. tmpdir:gsub("\\", "/") .. [[/rock_b_01.lua"
+               }
+               build = {
+                  type = "builtin", 
+                  modules = {
+                     rock_b = "rock_b_01.lua"
+                  }
+               }
+            ]], finally)
+   
+            write_file("rock_b_10.lua", "print('ROCK B 1.0'); return {}", finally)
+            write_file("rock_b-1.0-1.rockspec", [[
+               package = "rock_b"
+               version = "1.0-1"
+               source = {
+                  url = "file://]] .. tmpdir:gsub("\\", "/") .. [[/rock_b_10.lua"
+               }
+               build = {
+                  type = "builtin", 
+                  modules = {
+                     rock_b = "rock_b_10.lua"
+                  }
+               }
+            ]], finally)
+   
+            write_file("rock_a.lua", "require('rock_b'); return {}", finally)
+            write_file("rock_a-2.0-1.rockspec", [[
+               package = "rock_a"
+               version = "2.0-1"
+               source = {
+                  url = "file://]] .. tmpdir:gsub("\\", "/") .. [[/rock_a.lua"
+               }
+               dependencies = {
+                  "rock_b < 1.0",
+               }
+               build = {
+                  type = "builtin", 
+                  modules = {
+                     rock_a = "rock_a.lua"
+                  }
+               }
+            ]], finally)
+
+            print(run.luarocks("make --server=" .. testing_paths.fixtures_dir .. "/a_repo --tree=" .. testing_paths.testing_tree .. " ./rock_b-0.1-1.rockspec"))
+            print(run.luarocks("make --server=" .. testing_paths.fixtures_dir .. "/a_repo --tree=" .. testing_paths.testing_tree .. " ./rock_b-1.0-1.rockspec --keep"))
+            print(run.luarocks("make --server=" .. testing_paths.fixtures_dir .. "/a_repo --tree=" .. testing_paths.testing_tree .. " ./rock_a-2.0-1.rockspec"))
+   
+            local output = run.lua([[-e "require 'luarocks.loader'; require('rock_a')"]])
+   
+            assert.matches("ROCK B 0.1", output, 1, true)
+         end)
+      end)
+   end)
 end)
-- 
cgit v1.2.3-55-g6feb