Almost ready for beta3

1 files changed, 43 insertions, 10 deletions

diff --git a/src/ftp.lua b/src/ftp.lua
index 9902c88..4529acd 100644
--- a/src/ftp.lua
+++ b/src/ftp.lua
@@ -8,13 +8,15 @@
 -----------------------------------------------------------------------------
 -- Declare module and import dependencies
 -----------------------------------------------------------------------------
+local base = require("base")
+local table = require("table")
+local string = require("string")
+local math = require("math")
 local socket = require("socket")
 local url = require("socket.url")
 local tp = require("socket.tp")
-
 local ltn12 = require("ltn12")
-
-module("socket.ftp")
+local ftp = module("socket.ftp")
 
 -----------------------------------------------------------------------------
 -- Program constants
@@ -35,7 +37,7 @@ local metat = { __index = {} }
 
 function open(server, port)
     local tp = socket.try(tp.connect(server, port or PORT, TIMEOUT))
-    local f = setmetatable({ tp = tp }, metat)
+    local f = base.setmetatable({ tp = tp }, metat)
     -- make sure everything gets closed in an exception
     f.try = socket.newtry(function() f:close() end)
     return f 
@@ -102,7 +104,8 @@ function metat.__index:send(sendt)
     -- we just get the data connection into self.data
     if self.pasvt then self:pasvconnect() end
     -- get the transfer argument and command 
-    local argument = sendt.argument or string.gsub(sendt.path, "^/", "")
+    local argument = sendt.argument or 
+        url.unescape(string.gsub(sendt.path or "", "^/", ""))
     if argument == "" then argument = nil end
     local command = sendt.command or "stor"
     -- send the transfer command and check the reply
@@ -134,7 +137,8 @@ end
 function metat.__index:receive(recvt)
     self.try(self.pasvt or self.server, "need port or pasv first")
     if self.pasvt then self:pasvconnect() end
-    local argument = recvt.argument or string.gsub(recvt.path, "^/", "")
+    local argument = recvt.argument or 
+        url.unescape(string.gsub(recvt.path or "", "^/", ""))
     if argument == "" then argument = nil end
     local command = recvt.command or "retr"
     self.try(self.tp:command(command, argument))
@@ -182,7 +186,19 @@ end
 -----------------------------------------------------------------------------
 -- High level FTP API
 -----------------------------------------------------------------------------
+function override(t)
+    if t.url then
+        u = url.parse(t.url)
+        for i,v in base.pairs(t) do
+            u[i] = v
+        end
+        return u
+    else return t end
+end
+
 local function tput(putt)
+    putt = override(putt)
+    socket.try(putt.host, "missing hostname")
     local f = open(putt.host, putt.port)
     f:greet()
     f:login(putt.user, putt.password)
@@ -201,8 +217,8 @@ local default = {
 
 local function parse(u)
     local t = socket.try(url.parse(u, default))
-    socket.try(t.scheme == "ftp", "invalid scheme '" .. t.scheme .. "'")
-    socket.try(t.host, "invalid host")
+    socket.try(t.scheme == "ftp", "wrong scheme '" .. t.scheme .. "'")
+    socket.try(t.host, "missing hostname")
     local pat = "^type=(.)$"
     if t.params then 
         t.type = socket.skip(2, string.find(t.params, pat))
@@ -219,11 +235,13 @@ local function sput(u, body)
 end
 
 put = socket.protect(function(putt, body)
-    if type(putt) == "string" then return sput(putt, body)
+    if base.type(putt) == "string" then return sput(putt, body)
     else return tput(putt) end
 end)
 
 local function tget(gett)
+    gett = override(gett)
+    socket.try(gett.host, "missing hostname")
     local f = open(gett.host, gett.port)
     f:greet()
     f:login(gett.user, gett.password)
@@ -242,7 +260,22 @@ local function sget(u)
     return table.concat(t)
 end
 
+command = socket.protect(function(cmdt)
+    cmdt = override(cmdt)
+    socket.try(cmdt.host, "missing hostname")
+    socket.try(cmdt.command, "missing command")
+    local f = open(cmdt.host, cmdt.port)
+    f:greet()
+    f:login(cmdt.user, cmdt.password)
+    f.try(f.tp:command(cmdt.command, cmdt.argument))
+    if cmdt.check then f.try(f.tp:check(cmdt.check)) end
+    f:quit()
+    return f:close()
+end)
+
 get = socket.protect(function(gett)
-    if type(gett) == "string" then return sget(gett)
+    if base.type(gett) == "string" then return sget(gett)
     else return tget(gett) end
 end)
+
+base.setmetatable(ftp, nil)