openbsd/src/lib/libc/net/freeaddrinfo.c, branch OPENBSD_7_9 A mirror of https://github.com/libressl/openbsd.git https://git.lua4.win/openbsd/atom?h=OPENBSD_7_9 2025-12-08T13:30:08+00:00 Do not crash when calling freeaddrinfo(NULL) 2025-12-08T13:30:08+00:00 jca 2025-12-08T13:30:08+00:00 urn:sha1:2a9ce651b1c5e84f70570a283e2a5ccd1e14eb25 Supported by Linux since at least 1997, and FreeBSD since 2017. While not defined, there's no real good reason to crash when we could just cope. Indeed, software out there relies on the Linux behavior. Point out in the manpage that the behavior of getaddrinfo(NULL) isn't defined and thus isn't portable. Edge case spotted recently by kn@ in OpenVPN. ok millert@ djm@ deraadt@ kn@ Delete casts to off_t and size_t that are implied by assignments 2016-09-21T04:38:56+00:00 guenther 2016-09-21T04:38:56+00:00 urn:sha1:4f42c802703f53d8169bb55766b44a362a136d7c or prototypes. Ditto for some of the char* and void* casts too. verified no change to instructions on ILP32 (i386) and LP64 (amd64) ok natano@ abluhm@ deraadt@ millert@ Remove NULL-checks before free() and a few related dead assignments. 2015-12-28T22:08:18+00:00 mmcc 2015-12-28T22:08:18+00:00 urn:sha1:70faac3485d844275c45acf2ad85cab3c2fa242d ok and valuable input from millert@ Finish wrapping <netdb.h> so that calls go direct and the symbols are all weak 2015-09-14T07:38:38+00:00 guenther 2015-09-14T07:38:38+00:00 urn:sha1:69d51e1e52740c86a8655750d6b847266c605ef4 ansify. ok deraadt@ moritz@ 2005-03-25T13:24:12+00:00 otto 2005-03-25T13:24:12+00:00 urn:sha1:2f490723a2e673b2457f65c4b06cacb7d700a3e8 add some missing $, ok djm@ 'That looks fine to me' millert@ 2004-10-01T04:08:45+00:00 jsg 2004-10-01T04:08:45+00:00 urn:sha1:286f2c9acc73fa2c79290ce6e5c7437d99f9f865 don't permit freeaddrinfo(NULL). now the behavior is consistent 2000-01-28T17:47:26+00:00 itojun 2000-01-28T17:47:26+00:00 urn:sha1:af545fafa6ab3bf7a4f91cc73e97df4db15930c1 across {free,net,open}bsd. both rfc2553 and X/Open spec are silent about the behavior, and there's no strong consensus either. i think library should NOT be forgiving in this case, to promote development of more robust 3rd-party codebase (code works on "freeaddrinfo(NULL) = SEGV" will work on "freeaddrinfo(NULL) is okay" environment, but not the other way around). only issue i have now is NRL freeaddrinfo() compatibility, which permits freeaddrinfo(NULL). avoid memory leakage on freeaddrinfo(). 2000-01-27T08:23:46+00:00 itojun 2000-01-27T08:23:46+00:00 urn:sha1:5b1f731bf4378d5cde8894a5aa27c652e69e5a5f (this bug was introduced since we mix KAME getaddrinfo and NRL freeaddrinfo). KNF 1999-06-23T22:14:51+00:00 deraadt 1999-06-23T22:14:51+00:00 urn:sha1:c9acd185820380c6eedba713cb86eaf97af03d53 Added some protocol independent interfaces (supposedly IPv6 support APIs, but 1999-06-23T21:55:29+00:00 cmetz 1999-06-23T21:55:29+00:00 urn:sha1:bdf7624d67f3bba1a3faed9abf0d2d27291c1cce ones that are useful for all protocols, not just IPv6).