openbsd/src/lib/libc/stdlib/lsearch.c, branch OPENBSD_7_9 A mirror of https://github.com/libressl/openbsd.git https://git.lua4.win/openbsd/atom?h=OPENBSD_7_9 2021-12-08T22:06:28+00:00 lsearch(3): reimplement using lfind(3) 2021-12-08T22:06:28+00:00 cheloha 2021-12-08T22:06:28+00:00 urn:sha1:8b24559bc32a8fcd130978a513c42659ebf278de lsearch(3) is really just lfind(3) with an additional branch to append the key if lfind(3) fails. If we get rid of the underlying linear_base() function and move the search portion into lfind(3) and the key-copying portion into lsearch(3) we get smaller and simpler code. Misc. notes: - We do not need to keep the historical comment about errno. lsearch(3) is pure computation and does not set errno. That's really all you need to know. The specification reserves no errors, either. - We are using lfind(3) internally now, so it switches from PROTO_DEPRECATED to PROTO_NORMAL in hidden/search.h and needs DEF_WEAK in stdlib/lsearch.c. With advice from guenther@ on symbol housekeeping in libc. Thread: https://marc.info/?l=openbsd-tech&m=163885187632449&w=2 ok millert@ lsearch(3): append key to array with memmove(3) instead of memcpy(3) 2021-12-07T04:01:45+00:00 cheloha 2021-12-07T04:01:45+00:00 urn:sha1:cfc78852fcba382d04261ab49ed38b22e811e417 If the key overlaps the end of the array, memcpy(3) mutates the key and copies a corrupted value into the end of the array. If we use memmove(3) instead we at least end up with a clean copy of the key at the end of the array. This is closer to the intended behavior. With input from millert@ and deraadt@. Thread: https://marc.info/?l=openbsd-tech&m=163880307403606&w=2 ok millert@ Change lsearch()'s "base" argument to require a non-const pointer to 2014-07-18T04:16:09+00:00 matthew 2014-07-18T04:16:09+00:00 urn:sha1:526aecf5e5a99b846201c093c8f4aed7d06676a7 align with POSIX and other systems. Pointed out by Elliott Hughes on tech ok deraadt rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and 2009-10-27T23:59:59+00:00 deraadt 2009-10-27T23:59:59+00:00 urn:sha1:4e04ad15cf88ddc52057cc9d19ae371de3d509c2 unmaintainable). these days, people use source. these id's do not provide any benefit, and do hurt the small install media (the 33,000 line diff is essentially mechanical) ok with the idea millert, ok dms add some missing $, ok djm@ 'That looks fine to me' millert@ 2004-10-01T04:08:45+00:00 jsg 2004-10-01T04:08:45+00:00 urn:sha1:286f2c9acc73fa2c79290ce6e5c7437d99f9f865 Remove the advertising clause in the UCB license which Berkeley 2003-06-02T20:18:38+00:00 millert 2003-06-02T20:18:38+00:00 urn:sha1:021d32a253720a2fcdb07690f59c7e08d1d661e6 rescinded 22 July 1999. Proofed by myself and Theo. move lsearch(3) and insque(3) from libcompat -> libc; they are now POSIX 2003-05-08T23:21:36+00:00 millert 2003-05-08T23:21:36+00:00 urn:sha1:904702870b8643c3707b8b8747e4c6814f2afa54