A mirror of https://github.com/libressl/openbsd.git https://git.lua4.win/openbsd/atom?h=libressl-v3.2.3 2020-09-06T06:41:03+00:00 2020-09-06T06:41:03+00:00 otto 2020-09-06T06:41:03+00:00 urn:sha1:764cad0b41a6709d8db171bee28134987f460c1a shaving off into the cache but unamp them. Pages in the cache get re-used and then a future grow of the first allocation will be hampered. Also make realloc a no-op for small shrinkage. ok deraadt@ 2020-05-27T22:25:09+00:00 schwarze 2020-05-27T22:25:09+00:00 urn:sha1:865d79a51cfbda059a32d59a45f9a8981dc6b7ff The bug, present since 4.4BSD, was that a trailing dash in an option group, when the dash is not permitted as an option letter, resulted in the whole option group being returned as an argument, even though the previous option in the group was already parsed as an option: OPTS=abc ./getopt-test -a- -c arg ===>> OPT(a)ARG(-a-)ARG(-c)ARG(arg). Instead, treat the dash as an invalid option and continue parsing options: ===>> OPT(a)ERR(?-)OPT(c)ARG(arg). The undesirable behaviour was that allowing the dash as an option letter only allowed isolated dashes ("-") and trailing dashes in groups ("-a-"), but neither middle dashes in groups ("-a-b"), even though that already partially worked in 4.4BSD, nor leading dashes in groups ("--a"), even though that works on all other BSDs and on glibc. Also, while POSIX does not require that the dash can be used as an option letter at all, arguably, it encourages that letters either be fully supported or not supported at all. It is dubious whether supporting an option letter in some positions but not in others can be considered conforming. This patch makes OpenBSD behaviour identical to FreeBSD and NetBSD, improves compatibility with glibc (except that glibc does not support isolated "-"), improves compatibility with DragonFly (except that DragonFly is buggy when the dash option letter can take an optional argument but that argument is not present), improves compatibility with Illumos and Solaris 11 (except those do not support "-" and mishandle "--a"), and restores 4.4BSD behaviour for "-a-b". In no respect i'm aware of is compatibility with any other systems reduced. For the full rationale, see my mail to tech@ on 30 Mar 2020 14:26:41 +0200. Part of the problem was originally reported by an anonymous coward on tech@ on 12 Mar 2020 03:40:24 +0200, additional analysis was contributed by martijn@, and then the OP sent the final version of the patch i'm now committing on 17 Mar 2020 19:17:56 +0200. No licensing problem here because after the commit, the file does not contain a single word written by the OP. Also, the OP told me in private mail that he intends to publish the patch under the ISC license already contained in the file and that he wishes to be known by the pseudonym "0xef967c36". OK martijn@, and no objection when shown on tech@, but commit delayed to stay clear of the release. 2020-04-26T16:36:14+00:00 schwarze 2020-04-26T16:36:14+00:00 urn:sha1:e46228d31b64bf4aabfbe1e7bafe0120ba40176c queue -> list; mention "intrusive"; element -> member at one place; delete a bogus remark that maybe referred to a long-gone implementation in VAX assembly code. Much more could be improved, but i don't want to waste too much time here. 2020-04-26T13:59:56+00:00 jmc 2020-04-26T13:59:56+00:00 urn:sha1:0740c14f7f520b95c1d09ed6d9195493ec4f2119 ok schwarze kill a Tn while here... 2020-03-30T12:52:58+00:00 martijn 2020-03-30T12:52:58+00:00 urn:sha1:f9d22e5bfb4a68abbe135cdcad92967c8344714c OK schwarze@ 2020-02-08T01:09:57+00:00 jsg 2020-02-08T01:09:57+00:00 urn:sha1:d9caa3efeb30ce5d25bc81064b9ae0dcc664699e Starting from "Combined Table of Contents" in Doug McIlroy's "A Research UNIX Reader" a table of which edition manuals appeared in. Checked against manuals from bitsavers/TUHS and source from TUHS where available. Ingo points out there are cases where something is included but not documented until a later release. bcd(6) v6 v7 printf(3) v2 v4 abort(3) v5 v6 system(3) v6 v7 fmod(3) v5 v6 ok schwarze@ 2020-01-13T18:05:10+00:00 stsp 2020-01-13T18:05:10+00:00 urn:sha1:022882865576c1a1e0596951c5df087f39ca4081 at the first non-option argument. I had to read source code to figure it out. 2019-12-20T19:16:40+00:00 tb 2019-12-20T19:16:40+00:00 urn:sha1:b2116ee7f867c3373e14c82f727d8d0021f69af5 From j@bitminer.ca with input from Andras Farkas, deraadt, joerg@netbsd "fix however you feel best!" jmc 2019-12-11T20:01:50+00:00 bluhm 2019-12-11T20:01:50+00:00 urn:sha1:be7e226cf1922696ae30c64b3eaacbbaa2f3a230 behavior. noticed by hshoexer@; OK beck@ 2019-09-14T13:16:50+00:00 otto 2019-09-14T13:16:50+00:00 urn:sha1:1403c773c21872e9d09f3939eaca11814e22d31d Prompted by guenther@