openbsd/src/lib/libc/string/strrchr.c, branch OPENBSD_7_9_BASEA mirror of https://github.com/libressl/openbsd.git
https://git.lua4.win/openbsd/atom?h=OPENBSD_7_9_BASE2018-10-01T06:37:37+00:00As per POSIX, when str{,r}chr is comparing it should convert c to a char.2018-10-01T06:37:37+00:00martijn2018-10-01T06:37:37+00:00urn:sha1:14762f7fed750ccdd7b8473696771f67b80a6639
The C implementation of str{,r}chr are not linked to the build, because
assembly implementations are used, but change to code for easier reference.
At least the i386 and amd64 are checked and seem to do the correct thing.
Found thanks to the csh any/strchr change.
minor pointers and OK millert@
Add framework for resolving (pun intended) libc namespace issues, using2015-08-31T02:53:57+00:00guenther2015-08-31T02:53:57+00:00urn:sha1:c1ccbe216c72b17e063c4c16fa4904d87d295c99
wrapper .h files and asm labels to let internal calls resolve directly and
not be overridable or use the PLT. Then, apply that framework to most of
the functions in stdio.h, string.h, err.h, and wchar.h. Delete the
should-have-been-hidden-all-along _v?(err|warn)[cx]? symbols while here.
tests clean on i386, amd64, sparc64, powerpc, and mips64
naming feedback from kettenis@ and millert@
ok kettenis@
Make index/rindex weak aliases of strchr/strrchr since they are not2015-05-15T22:29:37+00:00millert2015-05-15T22:29:37+00:00urn:sha1:8542b4252e10ee9efd45f44099d0c2f5b6ca5d53
part of the ISO C standard and have also been dropped from POSIX.
OK guenther@ kettenis@
restructure libc/string + libc/arch/*/string coperation regarding2014-11-30T19:43:57+00:00deraadt2014-11-30T19:43:57+00:00urn:sha1:d8f66904ee035f3e8b0d2d91fedb956995e16678
(potentially) MD versions (function dependent, not filename dependent)
split out memcpy/memmove/bcopy and strchr/index/strrchr/rindex
Bring back amd64 .S versions
And the final touch: switch all architectures temporarily to MI
memcpy.c, which contains syslog + abort for overlapping copies. A nice
harsh undefined behaviour. We will clean the entire userland of the
remaining issues in this catagory, then switch to the optimised memcpy
which skips the memmove check.
I tried to cut this change into pieces, but testing each sub-step on
every architecture is too time consuming and mindnumbing.
ok miod