A mirror of https://github.com/libressl/openbsd.git https://git.lua4.win/openbsd/atom?h=OPENBSD_7_1_BASE 2022-03-31T17:27:26+00:00 2022-03-31T17:27:26+00:00 naddy 2022-03-31T17:27:26+00:00 urn:sha1:3d8be07546f5ec331a0f851b0ea88212376ebb95 jmc@ dislikes a comma before "then" in a conditional, so leave those untouched. ok jmc@ 2022-03-29T18:15:52+00:00 naddy 2022-03-29T18:15:52+00:00 urn:sha1:bdf85107fe61cee7a4395de94b85298d6592c8ae ok jmc@ schwarze@ 2022-02-28T21:56:29+00:00 dtucker 2022-02-28T21:56:29+00:00 urn:sha1:3afe4b6f29d7548f490e80402e8bf0ef7229dac1 instances in the tree. ok deraadt@ 2022-02-26T16:14:42+00:00 otto 2022-02-26T16:14:42+00:00 urn:sha1:b9a07308bf393074d3bc822f5d326959d6620f23 in size. This cache is indexed by size (in # of pages), so it is very quick to check. Some programs allocate and deallocate larger allocations in a frantic way. Accomodate those programs by also keeping a cache of regions between 128k and 2M, in a cache of variable sized regions. Tested by many in snaps; ok deraadt@ 2022-02-06T00:29:02+00:00 jsg 2022-02-06T00:29:02+00:00 urn:sha1:330276f39a5e0d5b539d5e8e3e247384f82cbde2 ok jmc@ sthen@ millert@ 2022-01-06T18:58:24+00:00 jmc 2022-01-06T18:58:24+00:00 urn:sha1:bee4e7d6cff50954827dda49f2f9ca3cc0f570b4 from uwe@netbsd -r1.22 ok millert 2021-12-25T01:13:44+00:00 guenther 2021-12-25T01:13:44+00:00 urn:sha1:53c5e2cba9eff61f67c99cd18ea5209d02611f16 2021-12-08T22:06:28+00:00 cheloha 2021-12-08T22:06:28+00:00 urn:sha1:8b24559bc32a8fcd130978a513c42659ebf278de lsearch(3) is really just lfind(3) with an additional branch to append the key if lfind(3) fails. If we get rid of the underlying linear_base() function and move the search portion into lfind(3) and the key-copying portion into lsearch(3) we get smaller and simpler code. Misc. notes: - We do not need to keep the historical comment about errno. lsearch(3) is pure computation and does not set errno. That's really all you need to know. The specification reserves no errors, either. - We are using lfind(3) internally now, so it switches from PROTO_DEPRECATED to PROTO_NORMAL in hidden/search.h and needs DEF_WEAK in stdlib/lsearch.c. With advice from guenther@ on symbol housekeeping in libc. Thread: https://marc.info/?l=openbsd-tech&m=163885187632449&w=2 ok millert@ 2021-12-07T04:01:45+00:00 cheloha 2021-12-07T04:01:45+00:00 urn:sha1:cfc78852fcba382d04261ab49ed38b22e811e417 If the key overlaps the end of the array, memcpy(3) mutates the key and copies a corrupted value into the end of the array. If we use memmove(3) instead we at least end up with a clean copy of the key at the end of the array. This is closer to the intended behavior. With input from millert@ and deraadt@. Thread: https://marc.info/?l=openbsd-tech&m=163880307403606&w=2 ok millert@ 2021-12-02T20:58:01+00:00 cheloha 2021-12-02T20:58:01+00:00 urn:sha1:6cb312a90e0db659665950da1acb2da29d74cadf The "lim" variable needs to be a size_t to match nmemb, otherwise we get undefined behavior when nmemb exceeds INT_MAX. Prompted by a blog post by Joshua Bloch: https://ai.googleblog.com/2006/06/extra-extra-read-all-about-it-nearly.html Fixed by Chris Torek a long time ago: https://svnweb.freebsd.org/csrg/lib/libc/stdlib/bsearch.c?revision=51742&view=markup ok millert@