openbsd/src/lib/libcrypto/aes/aes_wrap.c, branch OPENBSD_6_8_BASE

Use memmove() instead of memcpy() to get rid of the need for

2018-11-07T18:31:16+00:00

non-overlapping *in and *out buffers as we're already implementing the "in place (un)wrapping" algorithms as given in RFC 3394. This removes a gratuitous API difference to OpenSSLin these undocumented functions. Found while working on wycheproof regress tests. ok beck jsing

RFC 3394 section 2 states that we need at least two 64 bit blocks

2018-10-20T15:53:09+00:00

for wrapping and, accordingly, three 64 bit blocks for unwrapping. That is: we need at least 16 bytes for wrapping and 24 bytes for unwrapping. This also matches the lower bounds that OpenSSL have in their CRYPTO_128_{un,}wrap() functions. In fact, if we pass an input with 'inlen < 8' to AES_unwrap_key(), this results in a segfault since then inlen -= 8 underflows. Found while playing with the Wycheproof keywrap test vectors. ok bcook

Correct spelling of OPENSSL_cleanse.

2015-09-10T15:56:26+00:00

ok miod@

Only import cryptlib.h in the four source files that actually need it.

2014-07-11T08:44:49+00:00

Remove the openssl public includes from cryptlib.h and add a small number of includes into the source files that actually need them. While here, also sort/group/tidy the includes. ok beck@ miod@

Stop including standard headers via cryptlib.h - pull in the headers that

2014-07-10T13:58:23+00:00

are needed in the source files that actually require them. ok beck@ miod@

tags as requested by miod and tedu

2014-06-12T15:49:31+00:00

Move the AES wrap test code into regress.

2014-05-30T15:17:43+00:00

if (x) free(x) -> free(x); semantic patch generated with coccinelle, carefully

2014-05-22T21:12:16+00:00

eyeballed before applying. Contributed by Cyril Roelandt on tech@

When compiling with AES_WRAP_TEST, make main() return a meaningful value

2014-04-22T21:27:15+00:00

instead of garbage, and add this to the libcrypto regress. Note these tests are incomplete, as they always use the default IV.

Change library to use intrinsic memory allocation functions instead of

2014-04-17T13:37:50+00:00

OPENSSL_foo wrappers. This changes: OPENSSL_malloc->malloc OPENSSL_free->free OPENSSL_relloc->realloc OPENSSL_freeFunc->free