openbsd/src/lib/libcrypto/arc4random/getentropy_osx.c, branch OPENBSD_7_9 A mirror of https://github.com/libressl/openbsd.git https://git.lua4.win/openbsd/atom?h=OPENBSD_7_9 2021-10-24T21:24:20+00:00 For open/openat, if the flags parameter does not contain O_CREAT, the 2021-10-24T21:24:20+00:00 deraadt 2021-10-24T21:24:20+00:00 urn:sha1:2cbc009da6303d81a98bd284aae87c1761b472c7 3rd (variadic) mode_t parameter is irrelevant. Many developers in the past have passed mode_t (0, 044, 0644, or such), which might lead future people to copy this broken idiom, and perhaps even believe this parameter has some meaning or implication or application. Delete them all. This comes out of a conversation where tb@ noticed that a strange (but intentional) pledge behaviour is to always knock-out high-bits from mode_t on a number of system calls as a safety factor, and his bewilderment that this appeared to be happening against valid modes (at least visually), but no sorry, they are all irrelevant junk. They could all be 0xdeafbeef. ok millert As done everywhere else, use a local version of MINIMUM() and avoid 2020-05-17T14:44:20+00:00 deraadt 2020-05-17T14:44:20+00:00 urn:sha1:032a35a73bdeb0ea0007bfc5219e6c96db991681 conflict against a potential define min() from some other scope. Saw a mention somewhere a while back that the gotdata() function in 2018-11-20T08:04:28+00:00 deraadt 2018-11-20T08:04:28+00:00 urn:sha1:1c9e20cbc776ff1a1ba01d20a3d7ae740718e16e here could creates non-uniformity since very short fetches of 0 would be excluded. blocks of 0 are just as random as any other data, including blocks of 4 4 4.. This is a misguided attempt to identify errors from the entropy churn/gather code doesn't make sense, errors don't happen. ok bcook add iOS support for getentropy 2016-09-03T15:24:09+00:00 bcook 2016-09-03T15:24:09+00:00 urn:sha1:fc45c32b727123a9db48fbc11ff7d90f36199048 from Jacob Berkman, ok beck@ Update the link for the getentropy(2) manual to man.openbsd.org/ 2016-08-07T03:27:21+00:00 tb 2016-08-07T03:27:21+00:00 urn:sha1:45a99457661a695d9e6070e26d9383b3a955a536 ok deraadt@ unify files further 2015-09-11T11:52:55+00:00 deraadt 2015-09-11T11:52:55+00:00 urn:sha1:2a8f39dde4eb3fc8b492e8c665128c557ff500af Use explicit_bzero() instead of memset() on buffers going out of scope. 2014-07-21T20:19:47+00:00 guenther 2014-07-21T20:19:47+00:00 urn:sha1:0872907b62794cd6aa17af938318ed13aef2aecc Also, zero the SHA256 context. suggested by "eric" in a comment on an opensslrampage.org post ok miod@ deraadt@ remove disabled main hook; we use phdr now; ok bcook 2014-07-19T16:12:00+00:00 deraadt 2014-07-19T16:12:00+00:00 urn:sha1:7d86fd87164e886f422ae29e3aab9bf04502316d Provide a link to the canonical API specification. 2014-07-13T13:03:09+00:00 deraadt 2014-07-13T13:03:09+00:00 urn:sha1:3eef0b7f101f6ffe732366f0ba4b4e78c672a5f7 ok beck Take away the use of the address of main as a source of entropy. Causes 2014-07-13T08:24:20+00:00 beck 2014-07-13T08:24:20+00:00 urn:sha1:9dc40c4cb8a8d7a877ed1c8f5bc3cbc3f2ac2851 distractions to people testing and seeing link errors in some setups. This will come back in another form ok deraadt@