openbsd/src/lib/libcrypto/arc4random, branch master A mirror of https://github.com/libressl/openbsd.git https://git.lua4.win/openbsd/atom?h=master 2022-12-26T07:18:53+00:00 spelling fixes; from paul tagliamonte 2022-12-26T07:18:53+00:00 jmc 2022-12-26T07:18:53+00:00 urn:sha1:2eb7e5ff6bb69760f9dd4a43e7e3520ebb930120 i removed the arithmetics -> arithmetic changes, as i felt they were not clearly correct ok tb For open/openat, if the flags parameter does not contain O_CREAT, the 2021-10-24T21:24:20+00:00 deraadt 2021-10-24T21:24:20+00:00 urn:sha1:2cbc009da6303d81a98bd284aae87c1761b472c7 3rd (variadic) mode_t parameter is irrelevant. Many developers in the past have passed mode_t (0, 044, 0644, or such), which might lead future people to copy this broken idiom, and perhaps even believe this parameter has some meaning or implication or application. Delete them all. This comes out of a conversation where tb@ noticed that a strange (but intentional) pledge behaviour is to always knock-out high-bits from mode_t on a number of system calls as a safety factor, and his bewilderment that this appeared to be happening against valid modes (at least visually), but no sorry, they are all irrelevant junk. They could all be 0xdeafbeef. ok millert Update getentropy on Windows to use Cryptography Next Generation (CNG). 2020-11-11T10:41:24+00:00 bcook 2020-11-11T10:41:24+00:00 urn:sha1:04553cc77265e9bcf5dc68d4dd6c2881fcb76177 wincrypt is deprecated and no longer works with newer Windows environments, such as in Windows Store apps. make fixed-sized fixed-value mib[] arrays be const 2020-10-12T22:08:33+00:00 deraadt 2020-10-12T22:08:33+00:00 urn:sha1:b7e57c0d7a138aac2289904709330d2b2ee7257c ok guenther tb millert As done everywhere else, use a local version of MINIMUM() and avoid 2020-05-17T14:44:20+00:00 deraadt 2020-05-17T14:44:20+00:00 urn:sha1:032a35a73bdeb0ea0007bfc5219e6c96db991681 conflict against a potential define min() from some other scope. Using pthread_atfork instead of __register_atfork with uClibc on noMMU 2019-07-11T10:37:28+00:00 inoguchi 2019-07-11T10:37:28+00:00 urn:sha1:c513fcc21523226bcda18cc239488f0508ef6e37 uClibc on noMMU doesn't provide __register_atfork(). Reported by redbirdtek on Github issue. https://github.com/libressl-portable/portable/issues/538 ok bcook@ Saw a mention somewhere a while back that the gotdata() function in 2018-11-20T08:04:28+00:00 deraadt 2018-11-20T08:04:28+00:00 urn:sha1:1c9e20cbc776ff1a1ba01d20a3d7ae740718e16e here could creates non-uniformity since very short fetches of 0 would be excluded. blocks of 0 are just as random as any other data, including blocks of 4 4 4.. This is a misguided attempt to identify errors from the entropy churn/gather code doesn't make sense, errors don't happen. ok bcook ensure SYS_getrandom and GRND_NONBLOCK are both defined before using getrandom(2) 2018-03-13T22:53:28+00:00 bcook 2018-03-13T22:53:28+00:00 urn:sha1:302371947c6242ab9f7f993a57b4b413756adb5c Based on discussion here https://github.com/libressl-portable/openbsd/pull/82 Suggested fix from jsing@ Switch Linux getrandom() usage to non-blocking mode, continuing to 2017-04-29T18:43:31+00:00 beck 2017-04-29T18:43:31+00:00 urn:sha1:06e58ee3d445df182278c56c23d0bf1aec820070 use fallback mechanims if unsuccessful. The design of Linux getrandom is broken. It has an uninitialized phase coupled with blocking behaviour, which is unacceptable from within a library at boot time without possible recovery. ok deraadt@ jsing@ add iOS support for getentropy 2016-09-03T15:24:09+00:00 bcook 2016-09-03T15:24:09+00:00 urn:sha1:fc45c32b727123a9db48fbc11ff7d90f36199048 from Jacob Berkman, ok beck@