openbsd/src/lib/libcrypto/asn1/a_int.c, branch OPENBSD_7_9_BASE A mirror of https://github.com/libressl/openbsd.git https://git.lua4.win/openbsd/atom?h=OPENBSD_7_9_BASE 2025-05-10T05:54:39+00:00 Use err_local.h rather than err.h in most places 2025-05-10T05:54:39+00:00 tb 2025-05-10T05:54:39+00:00 urn:sha1:41e8f99dd1625a9f0c80ce9d4383e95b18e85709 ok jsing Hide global _it variables in asn1.h 2024-07-08T14:52:31+00:00 beck 2024-07-08T14:52:31+00:00 urn:sha1:3e4afb686e802ed188471899b25a031f4c4164af ok tb@ Hide symbols in asn1 and bio 2023-07-05T21:23:37+00:00 beck 2023-07-05T21:23:37+00:00 urn:sha1:0da1913b3c721e1a62fd66bc43547b4e910cbc34 ok jsing@ Encode an ASN.1 INTEGER with NULL data to value of zero. 2022-08-28T17:49:25+00:00 jsing 2022-08-28T17:49:25+00:00 urn:sha1:d065cbde3ee64dd2a8aff25147e1c4eaebac2787 When an ASN1_INTEGER is created it has NULL data until a value is set - previously, an ASN1_INTEGER in this state encoded to an ASN.1 INTEGER with a value of 0, rather than being treated as an error. While code should really set values, the historical behaviour has not required this. Found the hard way by sthen@ with acme-client. ok tb@ Rewrite i2c_ASN1_INTEGER() using CBB/CBS. 2022-08-20T18:17:33+00:00 jsing 2022-08-20T18:17:33+00:00 urn:sha1:f5720b925d89e12dd347d93f073d631d437b6a8a This gives us cleaner and safer code, although it is worth noting that we now generate the encoding even when called with NULL as the output pointer (and then discard it, returning just the length). Resolves oss-fuzz #49963. ok tb@ Cast int64_t to uint64_t before negating. 2022-07-13T20:07:44+00:00 jsing 2022-07-13T20:07:44+00:00 urn:sha1:aab46b2cb1dcc736abbfa0465c423ddc885c72e9 Avoid undefined behaviour/integer overflow by casting an int64_t to uint64_t before negating. Fixes oss-fuzz #49043 ok tb@ Make ASN1_{INTEGER,ENUMERATED}_get() return 0 on NULL again 2022-07-09T14:46:43+00:00 tb 2022-07-09T14:46:43+00:00 urn:sha1:40868ef62b1c990379f28b723127ae704c232772 This is the documented behavior which got lost in the recent rewrite. Mismatch of documentation and reality pointed out by schwarze ok jsing Negate unsigned then cast to signed. 2022-06-28T19:44:28+00:00 jsing 2022-06-28T19:44:28+00:00 urn:sha1:4edad9b6e581e10291c227e2c7fb1f3a7a686cde Avoid undefined behaviour by negating the unsigned value, before casting to int64_t, rather than casting to int64_t then negating. Fixes oss-fuzz #48499 ok tb@ Rewrite ASN1_INTEGER_{get,set}() using CBS/CBB 2022-06-25T15:39:12+00:00 jsing 2022-06-25T15:39:12+00:00 urn:sha1:8ef1a055f89d01f797688b3e5e91fe78b910d79d In the process, prepare to provide ASN1_INTEGER_{get,set}_{u,}int64(). ok beck@ tb@ Simplify ASN1_INTEGER_cmp() 2022-06-25T14:22:54+00:00 jsing 2022-06-25T14:22:54+00:00 urn:sha1:f9ccf4bd285d47f617c1d7f0c47ed130881a289d ok beck@ tb@