openbsd/src/lib/libcrypto/asn1/a_object.c, branch OPENBSD_6_8_BASE A mirror of https://github.com/libressl/openbsd.git https://git.lua4.win/openbsd/atom?h=OPENBSD_6_8_BASE 2018-04-25T11:48:21+00:00 Add const to functions in asn1/asn1.h as they did in OpenSSL. 2018-04-25T11:48:21+00:00 tb 2018-04-25T11:48:21+00:00 urn:sha1:8092d4e5908838632c7363f83d8b8f13fd30cfaf BIO_f_asn1() will be taken care of later. Tested in a bulk by sthen ok bcook jca jsing use freezero() instead of memset/explicit_bzero + free. Substantially 2017-05-02T03:59:45+00:00 deraadt 2017-05-02T03:59:45+00:00 urn:sha1:5904cc0e04409fde39a97e6580535da34eeb4291 reduces conditional logic (-218, +82). MOD_EXP_CTIME_MIN_CACHE_LINE_WIDTH cache alignment calculation bn/bn_exp.c wasn'tt quite right. Two other tricky bits with ASN1_STRING_FLAG_NDEF and BN_FLG_STATIC_DATA where the condition cannot be collapsed completely. Passes regress. ok beck Send the function codes from the error functions to the bit bucket, 2017-01-29T17:49:23+00:00 beck 2017-01-29T17:49:23+00:00 urn:sha1:d1f47bd292f36094480caa49ada36b99a69c59b0 as was done earlier in libssl. Thanks inoguchi@ for noticing libssl had more reacharounds into this. ok jsing@ inoguchi@ don't dereference a if NULL 2016-11-06T17:04:48+00:00 bcook 2016-11-06T17:04:48+00:00 urn:sha1:7730a5f4a9fdc193de29b6010f94c160ddc06f9b simplify error handling in c2i_ASN1_OBJECT 2016-11-06T14:00:49+00:00 bcook 2016-11-06T14:00:49+00:00 urn:sha1:42bce16c83873657b57addca6d88aa13e2d620f8 ok beck@, miod@ explicit_bzero for asn1 objects on free. Too often these contain sensitive information 2016-03-17T03:51:49+00:00 beck 2016-03-17T03:51:49+00:00 urn:sha1:a40c5f7320dab09c9216fa636bbf22949be11912 and they should not be a performance bottleneck ok miod@ krw@ explict_bzero for some asn1 free's - ok miod@ 2016-03-06T18:05:00+00:00 beck 2016-03-06T18:05:00+00:00 urn:sha1:46c4bf4fb70d4a4a2f608347e391626b02e372db The IMPLEMENT_STACK_OF and IMPLEMENT_ASN1_SET_OF macros were turned into 2015-02-10T08:33:10+00:00 jsing 2015-02-10T08:33:10+00:00 urn:sha1:398669e54cc64c0b7d0a009b29cd2f2ff9063ca9 noops around 15 years ago. Remove multiple occurances of both that still exist in the code today. Fix CVE-2014-3508, pretty printing and OID validation: 2014-08-08T04:53:43+00:00 guenther 2014-08-08T04:53:43+00:00 urn:sha1:39cb4488ec5412e0f592f7fabdb5ab22cded5edc - make sure the output buffer is always NUL terminated if buf_len was initially greater than zero. - reject OIDs that are too long, too short, or not in proper base-127 Based on https://git.openssl.org/gitweb/?p=openssl.git;a=commit;h=0042fb5fd1c9d257d713b15a1f45da05cf5c1c87 ok bcook@ if (x) FOO_free(x) -> FOO_free(x). 2014-07-12T16:03:37+00:00 miod 2014-07-12T16:03:37+00:00 urn:sha1:068bf464df6ef084067943863d776f59762bfaf0 Improves readability, keeps the code smaller so that it is warmer in your cache. review & ok deraadt@