openbsd/src/lib/libcrypto/asn1/a_object.c, branch OPENBSD_7_9

Use err_local.h rather than err.h in most places

2025-05-10T05:54:39+00:00

ok jsing

Hide global _it variables in asn1.h

2024-07-08T14:52:31+00:00

ok tb@

Fix i2d_ASN1_OBJECT()

2024-05-29T16:14:38+00:00

When called with a pointer to NULL as an output buffer, one would expect an i2d API to allocate the buffer and return it. The implementation here is special and the allocation dance was forgotten, resulting in a SIGSEGV. Add said dance. ok jsing

Make i2d_ASN1_OBJECT() return -1 on error

2024-05-29T16:10:41+00:00

This is what the (not quite appropriately) referenced ASN1_item_i2d() page documents for errors, matches what the RETURN VALUE section has been documenting for ages, matches BoringSSL, it's the usal behavior for i2d_*. It's also what OpenSSL (of course incorrectly) documents. discussed with jsing

Remove unnecessary parens from i2d_ASN1_OBJECT()

2024-05-29T16:04:50+00:00

Hide symbols in asn1 and bio

2023-07-05T21:23:37+00:00

ok jsing@

Simplify OBJ_obj2txt()

2023-05-23T11:51:12+00:00

Instead of adding a NUL termination to OBJ_obj2txt(), move the aobj == NULL or aobj->data == NULL checks to i2t_ASN1_OBJECT_internal(). The only other caller, i2t_ASN1_OBJECT(), fails on aobj == NULL and aobj->length == 0, and the latter condition is implied by aobj->data. Cleaner solution for obj_dat.c r1.52 suggested by/ok jsing

Make internal header file names consistent

2022-11-26T16:08:57+00:00

Libcrypto currently has a mess of *_lcl.h, *_locl.h, and *_local.h names used for internal headers. Move all these headers we inherited from OpenSSL to *_local.h, reserving the name *_internal.h for our own code. Similarly, move dtls_locl.h and ssl_locl.h to dtls_local and ssl_local.h. constant_time_locl.h is moved to constant_time.h since it's special. Adjust all .c files in libcrypto, libssl and regress. The diff is mechanical with the exception of tls13_quic.c, where #include was fixed manually. discussed with jsing, no objection bcook

Fix d2i_ASN1_OBJECT()

2022-05-13T16:32:10+00:00

Due to a confusion of two CBS, the API would incorrectly advance the *der_in pointer, resulting in a DER parse failure. Issue reported by Aram Sargsyan ok jsing

Convert asn1_ex_c2i() to CBS.

2022-04-23T18:47:08+00:00

This allows us to make direct use of c2i_ASN1_OBJECT_cbs(). ok inoguchi@ tb@