openbsd/src/lib/libcrypto/asn1, branch OPENBSD_6_4_BASE A mirror of https://github.com/libressl/openbsd.git https://git.lua4.win/openbsd/atom?h=OPENBSD_6_4_BASE 2018-09-17T18:18:01+00:00 Simplify initialization of asn1_cb; use correct spelling of NULL. 2018-09-17T18:18:01+00:00 tb 2018-09-17T18:18:01+00:00 urn:sha1:f0f374ba92c5b66a086071327dcd9e602dd74237 Add consts to EVP_PKEY_asn1_set_private() 2018-08-24T20:22:15+00:00 tb 2018-08-24T20:22:15+00:00 urn:sha1:b9a3c83c03543369636a655128b69d56eb619b83 Requires adding a const to the priv_decode() member of EVP_PKEY_ASN1_METHOD and adjusting all *_priv_decode() functions. All this is already documented this way. tested in a bulk build by sthen ok jsing After removing support for broken PKCS#8 formats (it was high time), 2018-08-24T20:17:33+00:00 tb 2018-08-24T20:17:33+00:00 urn:sha1:4cdbdc5207fa48804d8ed3a7929a97ae5f9f466d we can add const to PKCS8_pkey_get0(). In order for this to work, we need to sprinkle a few consts here and there. tested in a bulk by sthen ok jsing Remove EVP_PKEY2PKCS8_broken() and PKCS8_set_broken() 2018-08-24T20:07:42+00:00 tb 2018-08-24T20:07:42+00:00 urn:sha1:e4cf8ac5385c963bee0eb8d0e642abe1bb82ac78 Provide PKCS8_pkey_add1_attr_by_NID() and PKCS8_pkey_get0_attrs(). Remove the whole broken code and simplify pkcs8_priv_key_info_st accordingly. Based on OpenSSL commit 54dbf42398e23349b59f258a3dd60387bbc5ba13 plus some const that was added later. tested in a bulk build by sthen ok jsing Turn a number of #defines into proper functions with prototypes matching 2018-08-24T19:55:58+00:00 tb 2018-08-24T19:55:58+00:00 urn:sha1:d005d0528a66f69dbf8fb1a50b86c1bf40e135bc those that OpenSSL has had for ages. ok jsing Fix a memory leak in i2d_RSA_NET on failure of ASN1_STRING_set. 2018-08-05T13:35:45+00:00 bcook 2018-08-05T13:35:45+00:00 urn:sha1:0d240c50f7f6398b6c3318757e0e84305c126bfe Found by Coverity. Feedback and ok tb@ As calloc does the zeroing for us in EVP_PKEY_asn1_new() already, no need 2018-05-24T07:49:46+00:00 tb 2018-05-24T07:49:46+00:00 urn:sha1:06ea850e2b7cba7fb317ac8636a0a234e84fc72f to do it a second time by hand, badly. While here, do some style cleanup. This incomplete list of function pointers appears in EVP_PKEY_asn1_copy() as well, fix it by adding sig_print to the members copied over. ok bcook The 'in' argument of ASN1_STRING_to_UTF8() is now adorned with const. 2018-05-19T10:46:28+00:00 tb 2018-05-19T10:46:28+00:00 urn:sha1:73b269a8fb37ba753371257ee567a7074849f440 tested in a bulk build by sthen ok jsing Add a const qualifier to the 'X509_NAME *' argument of 2018-05-18T18:23:24+00:00 tb 2018-05-18T18:23:24+00:00 urn:sha1:5926c5b63c6dc5165df0ea09f9557f930bfb41ac X509_NAME_print{,_ex{,_fp}}(3). tested in a bulk build by sthen ok jsing Use recallocarray() instead of OPENSSL_realloc_clean(). 2018-05-13T13:48:08+00:00 jsing 2018-05-13T13:48:08+00:00 urn:sha1:675abe1d8052e9013aafab06d42a244160518f8c Also place all of the OPENSSL_* memory related prototypes under #ifndef LIBRESSL_INTERNAL. ok beck@ tb@