A mirror of https://github.com/libressl/openbsd.git https://git.lua4.win/openbsd/atom?h=OPENBSD_7_1_BASE 2022-04-10T12:42:33+00:00 2022-04-10T12:42:33+00:00 inoguchi 2022-04-10T12:42:33+00:00 urn:sha1:c694612e6569c6b13f7f2c75a3a1c4d9479509c2 'flags' should have ASN1_OBJECT_FLAG_DYNAMIC_DATA bit to free 'data' by ASN1_OBJECT_free as c2i_ASN1_OBJECT_cbs does. ok jsing@ tb@ 2022-03-31T13:04:47+00:00 tb 2022-03-31T13:04:47+00:00 urn:sha1:31dad1243d69de787b0589750cc4b78379c43734 p is allocated by asprintf() in one of the *_from_tm() functions, so it needs to be freed as in the other error path below. CID 346194 ok jsing 2022-03-26T14:54:58+00:00 jsing 2022-03-26T14:54:58+00:00 urn:sha1:20c8d5e654c79295ab91cfcd49160d5d096494bd Along the way, rather than having yet another piece of code that parses OID arcs, reuse oid_parse_arc(). Always allocate a new ASN1_OBJECT rather than doing a crazy dance with ASN1_OBJECT_FLAG_DYNAMIC and trying to free parts of an ASN1_OBJECT if one is passed in. ok inoguchi@ tb@ 2022-03-26T14:47:58+00:00 jsing 2022-03-26T14:47:58+00:00 urn:sha1:d10bc75275e54a97decc3a71a607af1535e2f2b3 This takes a CBS, gets the ASN.1 identifier and length, ensures the resulting identifier is a valid primitive, then returns the tag number and the content as a CBS. ok inoguchi@ tb@ 2022-03-20T13:27:23+00:00 jsing 2022-03-20T13:27:23+00:00 urn:sha1:775717706ed7c9e5ad063f73c0e54505da7f01f8 2022-03-19T17:49:32+00:00 jsing 2022-03-19T17:49:32+00:00 urn:sha1:2b63d13b51dbcbb4817452fa7523918d166ddd55 The current OBJ_txt2obj() implementation converts the text to ASN.1 object content octets, builds a full DER encoding from it, then feeds the entire thing back through the DER to ASN.1 object conversion. Rather than doing this crazy dance, provide an t2i_ASN1_OBJECT_internal() function that converts the text to ASN.1 object content octets, then creates a new ASN1_OBJECT and attaches the content octets to it. ok inoguchi@ tb@ 2022-03-19T17:35:52+00:00 jsing 2022-03-19T17:35:52+00:00 urn:sha1:9de5efcb223141c12ce6556e822cda9d1d160c25 Rewrite the ascii/text to ASN.1 object conversion code using CBB/CBS, while also addressing some of the bizarre behaviour (such as allowing mixed separators and treating '..' as a zero value). ok inoguchi@ tb@ 2022-03-17T17:17:58+00:00 jsing 2022-03-17T17:17:58+00:00 urn:sha1:72f47231e7ca2316bbce70318f5d2705b5d11bba Rework ASN1_STRING_set() so that we always clear and free an existing allocation, prior to storing the new data. This fixes a number of issues, including a failure to zero data if the existing allocation was too small. This also fixes other bugs such as leaving the allocation uninitialised if NULL is passed for data. Require -1 where strlen() is expected and improve length and overflow checks. ok inoguchi@ tb@ 2022-03-15T18:47:22+00:00 jsing 2022-03-15T18:47:22+00:00 urn:sha1:5ad5879113588eef4d693bcf7e8a51f803641921 ok tb@ 2022-03-14T16:35:45+00:00 jsing 2022-03-14T16:35:45+00:00 urn:sha1:ed6d95418f799a0e00e49deb2fe14e76912fb1d9 This fixes a bug in ASN1_STRING_set0() where it does not respect the ASN1_STRING_FLAG_NDEF flag and potentially frees memory that we do not own. ok inguchi@ tb@