openbsd/src/lib/libcrypto/asn1, branch libressl-v3.5.1A mirror of https://github.com/libressl/openbsd.git
https://git.lua4.win/openbsd/atom?h=libressl-v3.5.12022-03-13T14:58:14+00:00Remove free_cont from asn1_d2i_ex_primitive()/asn1_ex_c2i().2022-03-13T14:58:14+00:00jsing2022-03-13T14:58:14+00:00urn:sha1:fa2518a98adbc41d019ee1af4e3eb7fd994861b2
The constructed ASN.1 handling in asn1_d2i_ex_primitive() and asn1_ex_c2i()
currently has code to potentially avoid a malloc/memcpy - this is a less
common code path and it introduces a bunch of complexity for minimal gain.
In particular, we're manually adding a trailing NUL when ASN1_STRING_set()
would already do that for us, plus we currently manually free() the data on
an ASN1_STRING, rather than using freezero().
ok inoguchi@ tb@
Do not write out terminating NUL in i2a_ASN1_OBJECT()2022-03-03T08:06:57+00:00tb2022-03-03T08:06:57+00:00urn:sha1:62855c8784b772e2e48eb371a15223bb4f7dbb91
The conversion to CBB made us write out an extra NUL since we no longer
use the return value of i2t_ASN1_OBJECT() (which returns strlen(data))
but rather the size of the CBB (which includes a terminal NUL) to write
out data.
Issue found by anton via an openssl-ruby test failure.
ok jsing
whitespace2022-03-02T17:45:39+00:00tb2022-03-02T17:45:39+00:00urn:sha1:3b86371aee9e20fd7689aab2960dfbb85038af36Rewrite ASN1_OBJECT content to ascii/text conversion.2022-03-02T11:28:00+00:00jsing2022-03-02T11:28:00+00:00urn:sha1:82fb0381802967c4e0623e7f4bde8e684c08dbc6
Rewrite the ASN1_OBJECT content to ascii/text conversion code using CBB and
CBS. Currently there is a strange split with i2t_ASN1_OBJECT() calling
OBJ_obj2txt() which implements the conversion, while OBJ_txt2obj() calls
back into the misnamed a2d_ASN1_OBJECT() function. Move the conversion
code into asn1/a_object.c and have OBJ_txt2obj() call that instead.
ok inoguchi@ tb@
Get rid of SHA1 for comparing CRL's - use SHA512 just like we do for certs.2022-02-24T22:05:07+00:00beck2022-02-24T22:05:07+00:00urn:sha1:e29735531148d227a52ccd6fa19e0b2cdf8b7b83
ok tb@
Avoid potential single byte overread in asn1_parse2().2022-02-12T03:07:24+00:00jsing2022-02-12T03:07:24+00:00urn:sha1:4f6b3f124aaba62ebcf7e04e6536475e0aa3d1d2
A fix for this was previously commited in r1.32, however while this added
a bounds check the logic means we still fall through and perform the
overread. Fix the logic such that we only log the error if the bounds check
fails. While here, flip the test around such that we check for validity then
print (which is more readable and matches earlier code).
ok inoguchi@ tb@
Add check for BIO_indent return value2022-01-20T10:49:56+00:00inoguchi2022-01-20T10:49:56+00:00urn:sha1:2613c19661207cfecafb7cfef7fb47e0e74600b1
CID 24869
ok jsing@ millert@ tb@
Avoid buffer overflow in asn1_parse22022-01-14T23:55:46+00:00inoguchi2022-01-14T23:55:46+00:00urn:sha1:d00af36e612a46a6acda87f7b192bd40352e4df2
asn1_par.c r1.29 changed to access p[0] directly, and this pointer could be
overrun since ASN1_get_object advances pointer to the first content octet.
In case invalid ASN1 Boolean data, it has length but no content, I thought
this could be happen.
Adding check p with tot (diff below) will avoid this failure.
Reported by oss-fuzz 43633 and 43648(later)
ok tb@
Move ASN1_BOOLEAN to internal only.2022-01-14T08:53:53+00:00tb2022-01-14T08:53:53+00:00urn:sha1:816ec8c5aa2b60be0f26dcb7bfd51516e4bcad77
This moves {d2i,i2d}_ASN1_BOOLEAN() to internal only. They are unused,
but help us testing the encoding.
ok jsing
Remove all asn1_* symbols from public visibility2022-01-14T08:43:06+00:00tb2022-01-14T08:43:06+00:00urn:sha1:3abd0e5eb0202ac6a1161b1192742dc6a649a164
ok inoguchi jsing