openbsd/src/lib/libcrypto/bio/b_dump.c, branch OPENBSD_6_8_BASEA mirror of https://github.com/libressl/openbsd.git
https://git.lua4.win/openbsd/atom?h=OPENBSD_6_8_BASE2015-04-23T06:11:19+00:00Do not need to buf[0] = 0 before strlcpy(buf, ...2015-04-23T06:11:19+00:00deraadt2015-04-23T06:11:19+00:00urn:sha1:3df6efe196d3800ced15968c2150a1178d09a381f{read,write} take a number of items and an item size as arguments, and2014-11-11T19:26:12+00:00miod2014-11-11T19:26:12+00:00urn:sha1:d2537ceeb86a4b72d3f8aab47db63f956fc1ac99
return the number of items read of written.
When you intend to return the number of bytes actually processed, it is
wise to pass 1 as the item size and the size as the number of items.
But in *some* places, the OpenSSL does the opposite, and has extra logic
to change a successful return of 1 (item processed) into the real size.
And, guess why it does that? Because of old VMS, for they (used to) have a
substandard stdio implementation.
Note that this change causes the return values of BIO_dump_fp() and
BIO_dump_indent_fp() to no longer be useless (actual number of callback calls),
but actual bytes output. Given the irrelevance of the return value before,
it is unlikely that anything depends upon it (and if something does, it
probably has other problems in need for a fix...)
ok tedu@ beck@ jsing@
Only import cryptlib.h in the four source files that actually need it.2014-07-11T08:44:49+00:00jsing2014-07-11T08:44:49+00:00urn:sha1:74e2c009c83ad374bd6acdcfc376a384e25ab007
Remove the openssl public includes from cryptlib.h and add a small number
of includes into the source files that actually need them. While here,
also sort/group/tidy the includes.
ok beck@ miod@
Stop including standard headers via cryptlib.h - pull in the headers that2014-07-10T13:58:23+00:00jsing2014-07-10T13:58:23+00:00urn:sha1:c917c683bc93c68fbf4310ac181f7906e76b3c94
are needed in the source files that actually require them.
ok beck@ miod@
tags as requested by miod and tedu2014-06-12T15:49:31+00:00deraadt2014-06-12T15:49:31+00:00urn:sha1:59f4f2c61d71e266d37dd2fc97615b3fd35b4721Everything sane has stdio, and FILE *. we don't need ifdefs for this.2014-05-29T20:21:23+00:00beck2014-05-29T20:21:23+00:00urn:sha1:f60b3b3365842d8869513a7e36981671cd726939
ok to firebomb from tedu@
Sort and group includes.2014-05-05T16:19:23+00:00jsing2014-05-05T16:19:23+00:00urn:sha1:dd76b70ee540a90047b18c07bee53ce49d9b7d20We'll interpret a (void) cast on snprintf() to mean it's been verified that2014-04-19T11:46:39+00:00guenther2014-04-19T11:46:39+00:00urn:sha1:15e0442b8cfbbc095af4db97db7cd2b6d8dc23d0
truncation is either desirable, not an issue, or is detected and handled later
ok deraadt@
use intrinsic strlcpy and strlcat everywhere so we only have one set of2014-04-19T00:41:38+00:00beck2014-04-19T00:41:38+00:00urn:sha1:73628bf3ecdcfc6ecfa2f0cb67009a8548e6659b
funcitons to check for incorrect use. keep BUF_strlcpy and BUF_strlcat
for API comptibility only.
ok tedu@
- Why do we hide from the OpenSSL police, dad?2014-04-16T19:54:20+00:00miod2014-04-16T19:54:20+00:00urn:sha1:8b189af5cdd592787ead69f8a0f378727a24b473
- Because they're not like us, son. They use macros to wrap stdio routines,
for an undocumented (OPENSSL_USE_APPLINK) use case, which only serves to
obfuscate the code.
ok tedu@