openbsd/src/lib/libcrypto/bio/bio_err.c, branch OPENBSD_7_9_BASEA mirror of https://github.com/libressl/openbsd.git
https://git.lua4.win/openbsd/atom?h=OPENBSD_7_9_BASE2024-06-24T06:43:23+00:00libcrypto: constify most error string tables2024-06-24T06:43:23+00:00tb2024-06-24T06:43:23+00:00urn:sha1:c9802a5afe29675d69b605ce906d34fd89c024ac
These constitute the bulk of the remaining global mutable state in
libcrypto. This commit moves most of them into data.rel.ro, leaving
out ERR_str_{functs,libraries,reasons} (which require a slightly
different approach) and SYS_str_reasons which is populated on startup.
The main observation is that if ERR_load_strings() is called with a 0 lib
argument, the ERR_STRING_DATA argument is not actually modified. We could
use this fact to cast away const on the caller side and be done with it.
We can make this cleaner by adding a helper ERR_load_const_strings() which
explicitly avoids the assignment to str->error overriding the error code
already set in the table.
In order for this to work, we need to sprinkle some const in err/err.c.
CMS called ERR_load_strings() with non-0 lib argument, but this didn't
actually modify the error data since it ored in the value already stored
in the table.
Annoyingly, we need to cast const away once, namely in the call to
lh_insert() in int_err_set_item(). Fixing this would require changing
the public API and is going to be tricky since it requires that the
LHASH_DOALL_FN_* types adjust.
ok jsing
Hide symbols in asn1 and bio2023-07-05T21:23:37+00:00beck2023-07-05T21:23:37+00:00urn:sha1:0da1913b3c721e1a62fd66bc43547b4e910cbc34
ok jsing@
Remove mkerr.pl remnants from LibreSSL2022-07-12T14:42:50+00:00kn2022-07-12T14:42:50+00:00urn:sha1:89e42d5857196a8071fbafb5565388d0e20ec32b
This script is not used at all and files are edited by hand instead.
Thus remove misleading comments incl. the obsolete script/config.
Feedback OK jsing tb
Implement new-style OpenSSL BIO callbacks2022-01-14T08:40:57+00:00tb2022-01-14T08:40:57+00:00urn:sha1:bf7beecb6c75655f21958cd52426578df3f1f307
This provides support for new-style BIO callbacks in
BIO_{read,write,gets,puts}() and a helper function to
work out whether it should call the new or the old
style callback. It also adds a few typedefs and minor
code cleanup as well as the BIO_{get,set}_callback_ex()
from jsing, ok tb
Send the function codes from the error functions to the bit bucket,2017-01-29T17:49:23+00:00beck2017-01-29T17:49:23+00:00urn:sha1:d1f47bd292f36094480caa49ada36b99a69c59b0
as was done earlier in libssl. Thanks inoguchi@ for noticing
libssl had more reacharounds into this.
ok jsing@ inoguchi@
Explicitly include <openssl/opensslconf.h> in every file that references2014-07-10T22:45:58+00:00jsing2014-07-10T22:45:58+00:00urn:sha1:62348213609ef233110561d1a6ed67ad66df1c7e
an OPENSSL_NO_* define. This avoids relying on something else pulling it
in for us, plus it fixes several cases where the #ifndef OPENSSL_NO_XYZ is
never going to do anything, since OPENSSL_NO_XYZ will never defined, due
to the fact that opensslconf.h has not been included.
This also includes some miscellaneous sorting/tidying of headers.
In BIO_get_port(), use strol() with appropriate range checks rather than2014-06-22T14:41:10+00:00jsing2014-06-22T14:41:10+00:00urn:sha1:960a8f081914b4238bec3ed7791e4fdaf81ab7a1
an atoi() followed by an unsigned short cast. This stops things like "-1"
and "66536" from being considered to be "valid" port numbers.
ok beck@ deraadt@
tags as requested by miod and tedu2014-06-12T15:49:31+00:00deraadt2014-06-12T15:49:31+00:00urn:sha1:59f4f2c61d71e266d37dd2fc97615b3fd35b4721More KNF.2014-04-16T15:05:23+00:00jsing2014-04-16T15:05:23+00:00urn:sha1:0dc5f46224428f0ddf61596a00e25ce0e1ba18d4First pass at applying KNF to the OpenSSL code, which almost makes it2014-04-15T16:37:22+00:00jsing2014-04-15T16:37:22+00:00urn:sha1:405f0a76509e0e96df735b5b902a28b8ab6c9c55
readable. This pass is whitespace only and can readily be verified using
tr and md5.