openbsd/src/lib/libcrypto/bio/bss_file.c, branch OPENBSD_6_8_BASEA mirror of https://github.com/libressl/openbsd.git
https://git.lua4.win/openbsd/atom?h=OPENBSD_6_8_BASE2018-05-30T00:23:04+00:00Add a const qualifier to the return value of BIO_s_file().2018-05-30T00:23:04+00:00tb2018-05-30T00:23:04+00:00urn:sha1:ba417c1f27f6729e06c935d52544e49aa831b602
tested in a bulk build by sthen
ok bcook, jsing
Send the function codes from the error functions to the bit bucket,2017-01-29T17:49:23+00:00beck2017-01-29T17:49:23+00:00urn:sha1:d1f47bd292f36094480caa49ada36b99a69c59b0
as was done earlier in libssl. Thanks inoguchi@ for noticing
libssl had more reacharounds into this.
ok jsing@ inoguchi@
f{read,write} take a number of items and an item size as arguments, and2014-11-11T19:26:12+00:00miod2014-11-11T19:26:12+00:00urn:sha1:d2537ceeb86a4b72d3f8aab47db63f956fc1ac99
return the number of items read of written.
When you intend to return the number of bytes actually processed, it is
wise to pass 1 as the item size and the size as the number of items.
But in *some* places, the OpenSSL does the opposite, and has extra logic
to change a successful return of 1 (item processed) into the real size.
And, guess why it does that? Because of old VMS, for they (used to) have a
substandard stdio implementation.
Note that this change causes the return values of BIO_dump_fp() and
BIO_dump_indent_fp() to no longer be useless (actual number of callback calls),
but actual bytes output. Given the irrelevance of the return value before,
it is unlikely that anything depends upon it (and if something does, it
probably has other problems in need for a fix...)
ok tedu@ beck@ jsing@
Only import cryptlib.h in the four source files that actually need it.2014-07-11T08:44:49+00:00jsing2014-07-11T08:44:49+00:00urn:sha1:74e2c009c83ad374bd6acdcfc376a384e25ab007
Remove the openssl public includes from cryptlib.h and add a small number
of includes into the source files that actually need them. While here,
also sort/group/tidy the includes.
ok beck@ miod@
Stop including standard headers via cryptlib.h - pull in the headers that2014-07-10T13:58:23+00:00jsing2014-07-10T13:58:23+00:00urn:sha1:c917c683bc93c68fbf4310ac181f7906e76b3c94
are needed in the source files that actually require them.
ok beck@ miod@
tags as requested by miod and tedu2014-06-12T15:49:31+00:00deraadt2014-06-12T15:49:31+00:00urn:sha1:59f4f2c61d71e266d37dd2fc97615b3fd35b4721Any sane platform has stdio. Stop pretending we will ever use a platform2014-05-29T18:27:52+00:00beck2014-05-29T18:27:52+00:00urn:sha1:e79909cf30efce3949f375df3aef096d334eb6fe
that does not.
"fire bomb" tedu@
Use C99 initializers for the various FOO_METHOD structs. More readable, and2014-04-27T20:26:49+00:00miod2014-04-27T20:26:49+00:00urn:sha1:b5544d0885b7b6ceebce880a188724826a8fc5e9
avoid unreadable/unmaintainable constructs like that:
const EVP_PKEY_ASN1_METHOD cmac_asn1_meth =
{
EVP_PKEY_CMAC,
EVP_PKEY_CMAC,
0,
"CMAC",
"OpenSSL CMAC method",
0,0,0,0,
0,0,0,
cmac_size,
0,
0,0,0,0,0,0,0,
cmac_key_free,
0,
0,0
};
ok matthew@ deraadt@
Replace all use of ERR_add_error_data with ERR_asprintf_error_data.2014-04-26T18:56:38+00:00beck2014-04-26T18:56:38+00:00urn:sha1:e7dbd7a1e2ad3e12dafa2919bc8603d60416ea4d
This avoids a lot of ugly gymnastics to do snprintfs before sending the
bag of strings to ERR, and eliminates at least one place in dso_dlfctn.c
where it was being called with the incorrect number of arguments and
using random things off the stack as addresses of strings.
ok krw@, jsing@
use intrinsic strlcpy and strlcat everywhere so we only have one set of2014-04-19T00:41:38+00:00beck2014-04-19T00:41:38+00:00urn:sha1:73628bf3ecdcfc6ecfa2f0cb67009a8548e6659b
funcitons to check for incorrect use. keep BUF_strlcpy and BUF_strlcat
for API comptibility only.
ok tedu@