openbsd/src/lib/libcrypto/bio/bss_mem.c, branch OPENBSD_7_9_BASEA mirror of https://github.com/libressl/openbsd.git
https://git.lua4.win/openbsd/atom?h=OPENBSD_7_9_BASE2025-05-31T11:31:16+00:00Plug leak of bm->buf->data2025-05-31T11:31:16+00:00tb2025-05-31T11:31:16+00:00urn:sha1:410c2d0bcc144feb12f0d8a71338cd32edc4fcc9
BIO_new(BIO_s_mem()) now allocates this pointer, so we need to free it
before assigning to it.
Create bm->buf from the start to avoid arithmetic on NULL2025-05-24T19:45:34+00:00tb2025-05-24T19:45:34+00:00urn:sha1:8f9b910dab9bb415ae6b6c130c5e1d7bf9045d92
This is a different way of avoiding the pointer arithmetic on NULL and
avoids test breakage in pyca/cryptography. This is also a gross hack
that penalizes existing callers of BIO_s_mem(), but this is rarely
called in a hot loop and if so that will most likely be a test.
ok kenjiro joshua jsing
Revert "bio_mem: avoid pointer arithmetic on NULL"2025-05-24T19:43:09+00:00tb2025-05-24T19:43:09+00:00urn:sha1:fca273f703deb8e39e842b4028f0797813f40bbf
This causes a test failure in pyca/cryptography.
bio_mem: avoid pointer arithmetic on NULL2025-05-18T06:38:11+00:00tb2025-05-18T06:38:11+00:00urn:sha1:af1ef3c1489da1809c2ff641297daa2a8c023e75
Prompted by a diff by Kenjiro Nakayama
ok jsing
Use err_local.h rather than err.h in most places2025-05-10T05:54:39+00:00tb2025-05-10T05:54:39+00:00urn:sha1:41e8f99dd1625a9f0c80ce9d4383e95b18e85709
ok jsing
Hide symbols in asn1 and bio2023-07-05T21:23:37+00:00beck2023-07-05T21:23:37+00:00urn:sha1:0da1913b3c721e1a62fd66bc43547b4e910cbc34
ok jsing@
Reduce memmoves in memory BIOs.2022-02-19T15:59:12+00:00jsing2022-02-19T15:59:12+00:00urn:sha1:ecfbd0cd7a34e8b04af5f08a69bc02929f863d11
Currently, a read/write memory BIO pulls up the data via memmove() on each
read. This becomes very expensive when a lot of small reads are performed,
especially if there is a reasonable amount of data stored in the memory
BIO.
Instead, store a read offset into the buffer and only perform a memmove()
to pull up the data on a write, if we have read more than 4096 bytes. This
way we only perform memmove() when the space saving will potentially be of
benefit, while avoiding frequent memmove() in the case of small interleaved
reads and writes.
Should address oss-fuzz #19881.
ok inoguchi@ tb@
Provide a struct bio_mem for memory BIO specific data.2022-02-19T08:11:16+00:00jsing2022-02-19T08:11:16+00:00urn:sha1:5504d19c6403ab7e219eaf0b32151f79998f1d0d
In order to fix and improve the memory BIO, we need to be able to track
more than just a single BUF_MEM *. Provide a struct bio_mem (which
currently only contains a BUF_MEM *) and rework the internals to use this
struct.
ok inoguchi@ tb@
Clean up and simplify memory BIO code.2022-02-18T17:30:13+00:00jsing2022-02-18T17:30:13+00:00urn:sha1:e7ff7e9be98905e4e791056a5d6ec18f71fc52ff
This is a first pass that uses sensible and consistent names for variables.
Call the BIO 'bio' (instead of 'a', 'b', 'bp', or 'h'), drop a bunch of
unnecessary casts, simplify some logic and add additional error checking.
With input from and ok tb@
Add a new, mostly empty, bio_local.h and include it in the files2022-01-07T09:02:18+00:00tb2022-01-07T09:02:18+00:00urn:sha1:1eb53a0fe0ea503fe673aa0a6e347e503090c429
that will need it in the upcoming bump.
discussed with jsing