openbsd/src/lib/libcrypto/bio, branch OPENBSD_7_2

Make BIO_info_cb() identical to bio_info_cb()

2022-09-11T17:26:03+00:00

Various projects use bio_info_cb and BIO_info_cb interchangeably, for example mupdf and freerdp. This is because this was changed in OpenSSL commit fce78bd4 (2017), triggered by new warnings in gcc 8. https://github.com/openssl/openssl/pull/4493 This results in some scary compiler warnings and useless patches in ports. Nobody seems to be using the old bio_info_cb() version. ok jsing

Initialize readbytes in BIO_gets()

2022-08-15T10:48:45+00:00

If the bgets() callback returns <= 0, we currently rely on the user provided callback to set readbytes, which isn't ideal. This also matches what's done in BIO_read() and BIO_write(). ok jsing

Remove mkerr.pl remnants from LibreSSL

2022-07-12T14:42:50+00:00

This script is not used at all and files are edited by hand instead. Thus remove misleading comments incl. the obsolete script/config. Feedback OK jsing tb

Reduce memmoves in memory BIOs.

2022-02-19T15:59:12+00:00

Currently, a read/write memory BIO pulls up the data via memmove() on each read. This becomes very expensive when a lot of small reads are performed, especially if there is a reasonable amount of data stored in the memory BIO. Instead, store a read offset into the buffer and only perform a memmove() to pull up the data on a write, if we have read more than 4096 bytes. This way we only perform memmove() when the space saving will potentially be of benefit, while avoiding frequent memmove() in the case of small interleaved reads and writes. Should address oss-fuzz #19881. ok inoguchi@ tb@

Provide a struct bio_mem for memory BIO specific data.

2022-02-19T08:11:16+00:00

In order to fix and improve the memory BIO, we need to be able to track more than just a single BUF_MEM *. Provide a struct bio_mem (which currently only contains a BUF_MEM *) and rework the internals to use this struct. ok inoguchi@ tb@

Clean up and simplify memory BIO code.

2022-02-18T17:30:13+00:00

This is a first pass that uses sensible and consistent names for variables. Call the BIO 'bio' (instead of 'a', 'b', 'bp', or 'h'), drop a bunch of unnecessary casts, simplify some logic and add additional error checking. With input from and ok tb@

Implement new-style OpenSSL BIO callbacks

2022-01-14T08:40:57+00:00

This provides support for new-style BIO callbacks in BIO_{read,write,gets,puts}() and a helper function to work out whether it should call the new or the old style callback. It also adds a few typedefs and minor code cleanup as well as the BIO_{get,set}_callback_ex() from jsing, ok tb

Make structs in bio.h opaque

2022-01-14T08:18:55+00:00

Move BIO, BIO_METHOD and BIO_F_BUFFER_CTX to bio_local.h and provide BIO typedef in ossl_typ.h. ok inoguchi jsing

Remove BIO_s_file_internal

2022-01-14T07:59:32+00:00

Pointed out by schwarze. How something with this name ever made its way into a public header will remain a mystery. ok inoguchi jsing

Unifdef LIBRESSL_OPAQUE_* and LIBRESSL_NEXT_API

2022-01-14T07:49:49+00:00

This marks the start of major surgery in libcrypto. Do not attempt to build the tree for a while (~50 commits).