A mirror of https://github.com/libressl/openbsd.git https://git.lua4.win/openbsd/atom?h=OPENBSD_7_5 2024-03-02T09:22:41+00:00 2024-03-02T09:22:41+00:00 tb 2024-03-02T09:22:41+00:00 urn:sha1:28e50f56084f402001d1ee8df4967be93ce296e1 This used to be a dangerous implementation detail of BIO_new() that was never used outside of libcrypto. ok jsing 2024-03-02T09:21:24+00:00 tb 2024-03-02T09:21:24+00:00 urn:sha1:3be324ad741698effde1f32fdbee99994ab576d2 These were disabled and the internals that need to remain were fixed. Time for this garbage to go. ok jsing 2024-03-02T09:18:28+00:00 tb 2024-03-02T09:18:28+00:00 urn:sha1:624e55f48614f7c5aaa62d91eee54f0862c62db0 Unsued printing functionality. If something should need this we can readily add it back. ok jsing 2024-02-17T14:29:07+00:00 jsing 2024-02-17T14:29:07+00:00 urn:sha1:98b9e68c737460799750027fdf92680fb3a8c9c4 ok tb@ 2024-02-16T14:40:18+00:00 jsing 2024-02-16T14:40:18+00:00 urn:sha1:af87a7dd3c0694d817f79bb888637cbde0dc94a6 BIO_set() is a dangerous function that cannot be used safely. Thankfully, the only consumer is BIO_new(), hence inline the functionality and disable the BIO_set() function (for complete removal in the near future). ok tb@ 2024-02-16T14:27:43+00:00 jsing 2024-02-16T14:27:43+00:00 urn:sha1:cdb6b4d9599d838a2f7ccc4475fa3ebf477ac3ec Rather than 'a' or 'b', use 'bio' more consistently - there are still some more complex cases that have been left alone for now. Also use fewer parentheses. No change to generated assembly other than line numbers. 2024-02-15T10:34:30+00:00 tb 2024-02-15T10:34:30+00:00 urn:sha1:45f8e1de70fd627784044281c983866986be786a This API returns an int encoding the number of bytes printed. Thus, a dump of a large enough byte string can make this overflow and rely on undefined behavior. With an indent of 64, as little as 26 MB is enough to make this happen. ok jsing 2024-02-02T10:53:48+00:00 tb 2024-02-02T10:53:48+00:00 urn:sha1:989da4ff25e43b01aa92032006c42983562c68bd Instead of heaps of unchecked strlcpy/strlcat/snprintf doing hard to follow gymnastics, use a byte string, a somewhat comprehensible computation of the number of bytes to dump per output line and write using checked BIO_printf() directly to the BIO. Longer strings will still overflow the terminal width of 80 and even longer strings will still overflow the return value (undefined behavior). I don't care much about the former but the latter should be fixed in a later pass. ok beck 2024-02-01T17:04:09+00:00 tb 2024-02-01T17:04:09+00:00 urn:sha1:4eb78b51aee4bd5ba9d46d0026200ae12a29bf93 apache-httpd uses BIO_dump(), libssl uses BIO_dump_indent(), and the openssl(1) app uses both. Otherwise this is unused. This is horribly bad code even by libcrypto standards. By doing away with the callbacks fixes incorrect error checking for fwrite() but there is a lot more wrong in here. This can be cleaned up in a later pass, the only concern here is to be able to remove the unused variants in the next major bump. ok beck 2023-08-25T12:37:33+00:00 schwarze 2023-08-25T12:37:33+00:00 urn:sha1:5858a3e6cde0036b94090a94427298e8fa512fcd OK tb@ jsing@