openbsd/src/lib/libcrypto/bio, branch OPENBSD_7_7A mirror of https://github.com/libressl/openbsd.git
https://git.lua4.win/openbsd/atom?h=OPENBSD_7_72024-07-09T06:14:59+00:00Hide symbols for two missed public functions in bio.h2024-07-09T06:14:59+00:00beck2024-07-09T06:14:59+00:00urn:sha1:fae286b59acfdbc40328ed2618d5f50b375c2682
ok tb@
libcrypto: constify most error string tables2024-06-24T06:43:23+00:00tb2024-06-24T06:43:23+00:00urn:sha1:c9802a5afe29675d69b605ce906d34fd89c024ac
These constitute the bulk of the remaining global mutable state in
libcrypto. This commit moves most of them into data.rel.ro, leaving
out ERR_str_{functs,libraries,reasons} (which require a slightly
different approach) and SYS_str_reasons which is populated on startup.
The main observation is that if ERR_load_strings() is called with a 0 lib
argument, the ERR_STRING_DATA argument is not actually modified. We could
use this fact to cast away const on the caller side and be done with it.
We can make this cleaner by adding a helper ERR_load_const_strings() which
explicitly avoids the assignment to str->error overriding the error code
already set in the table.
In order for this to work, we need to sprinkle some const in err/err.c.
CMS called ERR_load_strings() with non-0 lib argument, but this didn't
actually modify the error data since it ored in the value already stored
in the table.
Annoyingly, we need to cast const away once, namely in the call to
lh_insert() in int_err_set_item(). Fixing this would require changing
the public API and is going to be tricky since it requires that the
LHASH_DOALL_FN_* types adjust.
ok jsing
remove prototypes with no matching function2024-05-19T07:12:50+00:00jsg2024-05-19T07:12:50+00:00urn:sha1:9dd363a8109e5383b08891f9d0307a5d5aa2bc09
feedback and ok tb@
bss_conn: zap trailing whitespace2024-04-19T09:54:36+00:00tb2024-04-19T09:54:36+00:00urn:sha1:6258e1e469c587f0bd2b0a4a20628e1ce855ebf7Move BIO_CONNECT_{new,free}() to internal-only2024-04-15T15:40:08+00:00tb2024-04-15T15:40:08+00:00urn:sha1:961023718870654e045ab2e43b6b02faf08ac784
ok jsing
Unify *_up_ref() implementations2024-03-27T01:22:30+00:00tb2024-03-27T01:22:30+00:00urn:sha1:34e2ca7d2d0a0fb4722dfa5e884d5657ea45d8f8
No need for an inconsistently named local variable and a ternary operator.
ok jsing
Remove BIO_set()2024-03-02T09:22:41+00:00tb2024-03-02T09:22:41+00:00urn:sha1:28e50f56084f402001d1ee8df4967be93ce296e1
This used to be a dangerous implementation detail of BIO_new() that was
never used outside of libcrypto.
ok jsing
Remove BIO_dump_*{cb,fp}()2024-03-02T09:21:24+00:00tb2024-03-02T09:21:24+00:00urn:sha1:3be324ad741698effde1f32fdbee99994ab576d2
These were disabled and the internals that need to remain were fixed.
Time for this garbage to go.
ok jsing
Remove BIO_{sn,v,vsn}printf(3)2024-03-02T09:18:28+00:00tb2024-03-02T09:18:28+00:00urn:sha1:624e55f48614f7c5aaa62d91eee54f0862c62db0
Unsued printing functionality. If something should need this we can readily
add it back.
ok jsing
Use calloc() instead of malloc() in BIO_new().2024-02-17T14:29:07+00:00jsing2024-02-17T14:29:07+00:00urn:sha1:98b9e68c737460799750027fdf92680fb3a8c9c4
ok tb@