A mirror of https://github.com/libressl/openbsd.git https://git.lua4.win/openbsd/atom?h=libressl-v2.1.2 2014-12-08T03:54:19+00:00 2014-12-08T03:54:19+00:00 bcook 2014-12-08T03:54:19+00:00 urn:sha1:41c42b2f9ee7871cfe1b0d9efed171117f462833 Casting a pointer to an unsigned long discards bits on an LLP64 system. ok deraadt@ 2014-12-03T22:14:38+00:00 bcook 2014-12-03T22:14:38+00:00 urn:sha1:dce88910ead3a43bc663d7d9e46e2689189ac19d Several functions that need to be redefined for a Windows port are right in the middle of other code that is relatively portable. This patch isolates the functions that need Windows-specific implementations so they can be built conditionally in the portable tree. ok jsing@ deraadt@ 2014-12-03T21:55:51+00:00 bcook 2014-12-03T21:55:51+00:00 urn:sha1:e9c7fab3c1b81bc2fc3cb67e4193168f2a194984 ok jsing@ deraadt@ 2014-11-26T05:41:44+00:00 bcook 2014-11-26T05:41:44+00:00 urn:sha1:55d80a958d30d205c03e1b28a8d9e28eb269f472 ok beck@ tedu@ miod@ guenther@ doug@ deraadt@ 2014-11-26T05:39:06+00:00 bcook 2014-11-26T05:39:06+00:00 urn:sha1:40f2ea8f2105a403b6b41914e7989498ef396fa4 ok beck@ tedu@ miod@ 2014-11-26T05:37:26+00:00 bcook 2014-11-26T05:37:26+00:00 urn:sha1:08cb5a5c87ab0fa71b2159d65417cfc7c2213ee2 Remove the remaining random casts on optval. Fixups for this can be handled by the portability layer all in once place. Remove remaining fake socklen_t unions, though beck@ points out that this also removes support for socklen_t changing its length at runtime. RIP. ok tedu@ beck@ miod@ deraadt@ 2014-11-26T05:01:47+00:00 bcook 2014-11-26T05:01:47+00:00 urn:sha1:0cbd89ae146a2a04009a43dcf0b4e1c7fd1e32ba ok beck@ miod@ tedu@ deraadt@ 2014-11-21T18:15:40+00:00 deraadt 2014-11-21T18:15:40+00:00 urn:sha1:fe6a0e09f387df024ba544da85022a04576823c5 2014-11-11T19:26:12+00:00 miod 2014-11-11T19:26:12+00:00 urn:sha1:d2537ceeb86a4b72d3f8aab47db63f956fc1ac99 return the number of items read of written. When you intend to return the number of bytes actually processed, it is wise to pass 1 as the item size and the size as the number of items. But in *some* places, the OpenSSL does the opposite, and has extra logic to change a successful return of 1 (item processed) into the real size. And, guess why it does that? Because of old VMS, for they (used to) have a substandard stdio implementation. Note that this change causes the return values of BIO_dump_fp() and BIO_dump_indent_fp() to no longer be useless (actual number of callback calls), but actual bytes output. Given the irrelevance of the return value before, it is unlikely that anything depends upon it (and if something does, it probably has other problems in need for a fix...) ok tedu@ beck@ jsing@ 2014-10-22T13:02:04+00:00 jsing 2014-10-22T13:02:04+00:00 urn:sha1:fa457604779ff38b511fdfdae3c6a78664281c22 arc4random_buf() is guaranteed to always succeed - it is worth noting that a number of the replaced function calls were already missing return value checks. ok deraadt@