openbsd/src/lib/libcrypto/bio, branch libressl-v3.4.1 A mirror of https://github.com/libressl/openbsd.git https://git.lua4.win/openbsd/atom?h=libressl-v3.4.1 2021-07-11T20:18:07+00:00 While the traditional OpenSSL return value and behaviour of BIO_dump(3) 2021-07-11T20:18:07+00:00 beck 2021-07-11T20:18:07+00:00 urn:sha1:60e361c7ad4d3810a5c94e8def304ac4427b9c59 is pure comedy gold, and now documented as such, sadly this bit of pure Muppet genius can't really in good consience stay in the tree as is. Change BIO_dump to always return the number of bytes printed on success and to stop printing and return -1 on failure if a writing function fails. ok tb@, jsing@ Avoid mangled output in BIO_debug_callback 2021-03-25T09:26:17+00:00 tb 2021-03-25T09:26:17+00:00 urn:sha1:0939b7a663a0450286c355c29910f9611128d2b0 Instead of blindly skipping 14 characters, we can use the return value of snprintf() to determine how much we should skip. From Martin Vahlensieck with minor tweaks by me failed to detect asprintf() error by observing return of -1, instead the 2019-06-28T05:47:57+00:00 deraadt 2019-06-28T05:47:57+00:00 urn:sha1:c1fcaeae79bc31f65b74c1825ddee23b90beee04 code was inspecting the pointer (which is, sadly, undefined on error, because the current specification of asprintf is crazy sloppy) Add input validation to BIO_read()/BIO_write(). 2019-04-14T17:39:03+00:00 jsing 2019-04-14T17:39:03+00:00 urn:sha1:43d312539a65f8db03988a53b94f1e6aa6e40f3c Some bread/bwrite functions implement this themselves, while others do not. This makes it consistent across all BIO implementations. Addresses an issue that Guido Vranken found with his fuzzer. ok tb@ Add const to the argument of the following callback getters: 2018-06-02T04:41:12+00:00 tb 2018-06-02T04:41:12+00:00 urn:sha1:e664354751e6274f4e304cea46e120e43dd41ade BIO_meth_get_callback_ctrl, BIO_meth_get_create, BIO_meth_get_ctrl, BIO_meth_get_destroy, BIO_meth_get_gets, BIO_meth_get_puts, BIO_meth_get_read, and BIO_meth_get_write. ok jsing Add a const qualifier to the return value of BIO_s_file(). 2018-05-30T00:23:04+00:00 tb 2018-05-30T00:23:04+00:00 urn:sha1:ba417c1f27f6729e06c935d52544e49aa831b602 tested in a bulk build by sthen ok bcook, jsing const qualifiers for BIO_new_mem_buf(), BIO_new_connect() and 2018-05-12T18:51:59+00:00 tb 2018-05-12T18:51:59+00:00 urn:sha1:1f5db40c0572d1f35b285265441091873a7f8c7f BIO_new_accept(). The one for BIO_new_mem_buf() is a bit ugly since it needs to cast away the newly added const qualifier, as in OpenSSL commit 8ab31975bac. ok jsing Add const qualifiers to the return values of BIO_s_mem() and 2018-05-12T17:47:53+00:00 tb 2018-05-12T17:47:53+00:00 urn:sha1:31d743443e7e064d16f4ba3a739b7c5a6b6361f0 BIO_s_datagram(). ok jsing const for BIO_{new,set}() and most of the BIO_{f,s}_*() family of 2018-05-01T13:29:10+00:00 tb 2018-05-01T13:29:10+00:00 urn:sha1:0348b99054499311191f1db880064066ce1c64b2 functions. ok beck, jsing Bring in compatibility for OpenSSL 1.1 style init functions. 2018-03-17T16:20:01+00:00 beck 2018-03-17T16:20:01+00:00 urn:sha1:035770aca4c8c1f0d36f1b8da62c9e1fb9a4f09b This adds OPENSSL_init_crypto and OPENSSL_init_ssl, as well thread safety modifications for the existing LibreSSL init functions. The initialization routines are called automatically by the normal entry points into the library, as in newer OpenSSL ok jsing@, nits by tb@ and deraadt@