A mirror of https://github.com/libressl/openbsd.git https://git.lua4.win/openbsd/atom?h=OPENBSD_7_9 2025-12-05T14:12:32+00:00 2025-12-05T14:12:32+00:00 tb 2025-12-05T14:12:32+00:00 urn:sha1:f3f05f0cf8c30a990193e332e26fdd8e54b3f59b This is a first sweep of reducing the number of terribly named macros in bn.h More can go away. Those we need internally go to bn_local.h. Annoyingly bn_internal.h uses some of them, so it includes bn_local.h now. This can be cleaned up later. ok jsing kenjiro 2025-05-10T05:54:39+00:00 tb 2025-05-10T05:54:39+00:00 urn:sha1:41e8f99dd1625a9f0c80ce9d4383e95b18e85709 ok jsing 2024-11-08T14:18:44+00:00 jsing 2024-11-08T14:18:44+00:00 urn:sha1:acc652186bbeb9458b641b1bffef14c7599bf465 Rewrite bn2binpad, removing some OpenSSL specific behaviour and unnecessary complexity. Our BN_num_bytes() does not return bogus lengths, so we don't need to see if things work out with nominated outputs. Swipe away some endianness_t, but continue to ignore negatives and don't dare give away padded zeroes. Implement a more readable constant time conversion. In particular, the little endian is the less common use case, which we can implement by reversing the padded output in place, rather than complicating all of the conversion code. ok beck@ tb@ 2024-06-22T16:33:00+00:00 jsing 2024-06-22T16:33:00+00:00 urn:sha1:46f3ac9ae9fffef6fa45edd1e316dc038aac3506 The content is effectively a u32 length prefixed field, so use CBB_add_u32_length_prefixed(). Use BN_bn2binpad() rather than manually padding if we need to extend and use sensible variable names so that the code becomes more readable. Note that since CBB can fail we now need to be able to indicate failure. This means that BN_bn2mpi() can now return -1 when it would not have previously (correct callers will check that BN_bn2mpi() returns a positive length). ok tb@ 2024-04-17T21:55:43+00:00 tb 2024-04-17T21:55:43+00:00 urn:sha1:fb1a8499f5efda58a4a49fccfe94fed7fde87d5d 2024-04-17T14:47:17+00:00 jsing 2024-04-17T14:47:17+00:00 urn:sha1:501a5fea8ddd4572c9635ad63b4e7bc7f4a42b76 ok tb@ 2024-04-17T14:45:46+00:00 jsing 2024-04-17T14:45:46+00:00 urn:sha1:57550569e5f6adbeb909274b4691bcb6888c78a0 We get an implementation of this for free by having bn_bin2bn_cbs() use CBS_get_u8() instead of CBS_get_last_u8(). ok tb@ 2024-04-16T13:14:46+00:00 jsing 2024-04-16T13:14:46+00:00 urn:sha1:a2d33edef120713fca38edea57eba33f8e3ba217 This results in simpler code. Suggested by tb@ during review. 2024-04-16T13:11:37+00:00 jsing 2024-04-16T13:11:37+00:00 urn:sha1:8616d66dbd9b93e2acc6f471938de8f646a5db24 ok tb@ 2024-04-16T13:04:05+00:00 jsing 2024-04-16T13:04:05+00:00 urn:sha1:0cf1dfb91461e728170657af9f15ff5bbb00d2f9 Also change the bits type from int to size_t, since that's what the callers are passing and we can avoid unnecessary input validation. ok tb@