openbsd/src/lib/libcrypto/bn/bn_ctx.c, branch OPENBSD_7_9_BASE

Use err_local.h rather than err.h in most places

2025-05-10T05:54:39+00:00

ok jsing

Hide symbols in bn

2023-07-08T12:21:58+00:00

ok tb@

Remove the no longer used BN_CTX_init()

2023-04-25T16:41:29+00:00

ok jsing

Rewrite BN_CTX.

2023-01-14T15:23:27+00:00

The current BN_CTX implementation is an incredibly overengineered piece of code, which even includes its own debug system. Rewrite BN_CTX from scratch, simplifying things things considerably by having a "stack" of BIGNUM pointers and a matching array of group assignments. This means that BN_CTX_start() and BN_CTX_end() effectively do not fail. Unlike the previous implementation, if a failure occurs nothing will work and the BN_CTX must be freed/recreated, instead of trying to pick up at the point where the failure occurred (which does not make sense given its intended usage). Additionally, it has long been documented that BN_CTX_start() must be called before BN_CTX_get() can be used, however the previous implementation did not actually enforce this. Now that missing BN_CTX_start() and BN_CTX_end() calls have been added to DSA and EC, we can actually make this a hard requirement. ok tb@

Mop up more BN_DEBUG related code.

2022-11-30T01:47:19+00:00

Make internal header file names consistent

2022-11-26T16:08:57+00:00

Libcrypto currently has a mess of *_lcl.h, *_locl.h, and *_local.h names used for internal headers. Move all these headers we inherited from OpenSSL to *_local.h, reserving the name *_internal.h for our own code. Similarly, move dtls_locl.h and ssl_locl.h to dtls_local and ssl_local.h. constant_time_locl.h is moved to constant_time.h since it's special. Adjust all .c files in libcrypto, libssl and regress. The diff is mechanical with the exception of tls13_quic.c, where #include was fixed manually. discussed with jsing, no objection bcook

Remove BIGNUM consistency macros.

2022-11-26T13:56:33+00:00

Compiling with BN_DEBUG (and if you want to take it further, BN_DEBUG_RAND) supposedly adds consistency checks to the BN code. These are rarely if ever used and introduce a bunch of clutter in the code. Furthermore, there are hacks in place to undo things that the debugging code does. Remove all of this mess and instead rely on always enabled checks, more readable code and proper regress coverage to ensure correct behaviour. "Good riddance." tb@

make BN_CTX_end(NULL) a NOOP for compatibility with documented behaviour

2019-08-20T10:59:09+00:00

in OpenSSL 1.1.1 even though in general, letting random functions accept NULL is not advisable because it can hide programming errors; "yes please" tb@ "unfortunately I suspect you're right" jsing@ "oh well" deraadt@

Send the function codes from the error functions to the bit bucket,

2017-01-29T17:49:23+00:00

as was done earlier in libssl. Thanks inoguchi@ for noticing libssl had more reacharounds into this. ok jsing@ inoguchi@

Remove unnecessary include of assert.h

2015-02-10T09:50:12+00:00