openbsd/src/lib/libcrypto/bn/bn_kron.c, branch OPENBSD_7_9_BASE

Hide symbols in bn

2023-07-08T12:21:58+00:00

ok tb@

Convert BN_copy() with explicit comparison against NULL to bn_copy()

2023-03-27T10:21:23+00:00

ok jsing

Zap an empty line

2023-03-25T10:51:18+00:00

Make internal header file names consistent

2022-11-26T16:08:57+00:00

Libcrypto currently has a mess of *_lcl.h, *_locl.h, and *_local.h names used for internal headers. Move all these headers we inherited from OpenSSL to *_local.h, reserving the name *_internal.h for our own code. Similarly, move dtls_locl.h and ssl_locl.h to dtls_local and ssl_local.h. constant_time_locl.h is moved to constant_time.h since it's special. Adjust all .c files in libcrypto, libssl and regress. The diff is mechanical with the exception of tls13_quic.c, where #include was fixed manually. discussed with jsing, no objection bcook

Remove BIGNUM consistency macros.

2022-11-26T13:56:33+00:00

Compiling with BN_DEBUG (and if you want to take it further, BN_DEBUG_RAND) supposedly adds consistency checks to the BN code. These are rarely if ever used and introduce a bunch of clutter in the code. Furthermore, there are hacks in place to undo things that the debugging code does. Remove all of this mess and instead rely on always enabled checks, more readable code and proper regress coverage to ensure correct behaviour. "Good riddance." tb@

Move BN_lsw() to bn_lcl.h so that other code can use it.

2022-07-12T16:08:19+00:00

ok jsing

Tweak a comment

2022-06-20T19:42:58+00:00

Flip roles of lowercase and uppercase A and B.

2022-06-20T19:38:25+00:00

This matches Cohen's text better and makes the entire thing easier to read. suggested by jsing

Clean up BN_kronecker()

2022-06-20T19:32:35+00:00

Instead of "Cohen's step N" explain in words what is being done. Things such as (A & B & 2) != 0 being equivalent to (-1)^((A-1)(B-1)/4) being negative are not entirely obvious... Remove the strange error dance and adjust variable names to what Cohen's book uses. Simplify various curly bits. ok jsing

BN_CTX_get() can fail - consistently check its return value.

2015-02-09T15:49:22+00:00

There are currently cases where the return from each call is checked, the return from only the last call is checked and cases where it is not checked at all (including code in bn, ec and engine). Checking the last return value is valid as once the function fails it will continue to return NULL. However, in order to be consistent check each call with the same idiom. This makes it easy to verify. Note there are still a handful of cases that do not follow the idiom - these will be handled separately. ok beck@ doug@