openbsd/src/lib/libcrypto/bn/bn_rand.c, branch OPENBSD_6_8_BASEA mirror of https://github.com/libressl/openbsd.git
https://git.lua4.win/openbsd/atom?h=OPENBSD_6_8_BASE2020-09-12T17:16:36+00:00Unindent a bit of code that performs a few too many checks to2020-09-12T17:16:36+00:00tb2020-09-12T17:16:36+00:00urn:sha1:ad25ca1fcd0c9ca48a2fcd6e68367cd74d82b01f
figure out whether top > 0 or top == 0.
Avoid an out-of-bounds access in BN_rand()2020-09-12T15:24:39+00:00tb2020-09-12T15:24:39+00:00urn:sha1:1e0b199599db7da1624618b2509c1d58106f35f7
If BN_rand() is called with top > 0 and bits == 1, it would allocate
a buf[] of size 1 and set the top bit of buf[1].
Found in OpenSSL commit efee575ad464bfb60bf72dcb73f9b51768f4b1a1 while
looking for something else.
ok beck djm inoguchi
Flip reversed test in bn_rand_interval().2018-11-06T06:49:45+00:00tb2018-11-06T06:49:45+00:00urn:sha1:a8249222cfc2738a9d25e498cd781c3b188cb9e0
ok jsing
Introduce bn_rand_interval() that allows specifying an interval [a, b)2018-11-05T23:52:47+00:00tb2018-11-05T23:52:47+00:00urn:sha1:180c3e4250e4e8ea8cdade42002a7fd6564d66c2
from which a a BIGNUM is chosen uniformly at random.
ok beck jsing
use freezero() instead of memset/explicit_bzero + free. Substantially2017-05-02T03:59:45+00:00deraadt2017-05-02T03:59:45+00:00urn:sha1:5904cc0e04409fde39a97e6580535da34eeb4291
reduces conditional logic (-218, +82).
MOD_EXP_CTIME_MIN_CACHE_LINE_WIDTH cache alignment calculation bn/bn_exp.c
wasn'tt quite right. Two other tricky bits with ASN1_STRING_FLAG_NDEF and
BN_FLG_STATIC_DATA where the condition cannot be collapsed completely.
Passes regress. ok beck
Send the function codes from the error functions to the bit bucket,2017-01-29T17:49:23+00:00beck2017-01-29T17:49:23+00:00urn:sha1:d1f47bd292f36094480caa49ada36b99a69c59b0
as was done earlier in libssl. Thanks inoguchi@ for noticing
libssl had more reacharounds into this.
ok jsing@ inoguchi@
Correct spelling of OPENSSL_cleanse.2015-09-10T15:56:26+00:00jsing2015-09-10T15:56:26+00:00urn:sha1:647569a51c1530d10e75e272f0982682f696caa7
ok miod@
If BN_rand() or BN_pseudo_rand() are called with a NULL rnd argument,2015-02-19T06:10:29+00:00jsing2015-02-19T06:10:29+00:00urn:sha1:62ebecd0e093eb1e8a47512de67da5c951069913
BN_bin2bn() will helpfully allocate a BN which is then leaked. Avoid this
by explicitly checking for NULL at the start of the bnrand() function.
Fixes Coverity ID 78831.
ok miod@
Use arc4random_buf() instead of RAND_bytes() or RAND_pseudo_bytes().2014-10-22T13:02:04+00:00jsing2014-10-22T13:02:04+00:00urn:sha1:fa457604779ff38b511fdfdae3c6a78664281c22
arc4random_buf() is guaranteed to always succeed - it is worth noting
that a number of the replaced function calls were already missing return
value checks.
ok deraadt@
Only import cryptlib.h in the four source files that actually need it.2014-07-11T08:44:49+00:00jsing2014-07-11T08:44:49+00:00urn:sha1:74e2c009c83ad374bd6acdcfc376a384e25ab007
Remove the openssl public includes from cryptlib.h and add a small number
of includes into the source files that actually need them. While here,
also sort/group/tidy the includes.
ok beck@ miod@