openbsd/src/lib/libcrypto/bn/bn_recp.c, branch OPENBSD_7_9_BASEA mirror of https://github.com/libressl/openbsd.git
https://git.lua4.win/openbsd/atom?h=OPENBSD_7_9_BASE2025-05-10T05:54:39+00:00Use err_local.h rather than err.h in most places2025-05-10T05:54:39+00:00tb2025-05-10T05:54:39+00:00urn:sha1:41e8f99dd1625a9f0c80ce9d4383e95b18e85709
ok jsing
bn_recp: reformat another ugly comment2025-02-04T20:22:20+00:00tb2025-02-04T20:22:20+00:00urn:sha1:2076aae78095fd10e70ad30d488bdf5e9964ca98Inline BN_reciprocal() in its only caller2025-02-04T12:47:58+00:00tb2025-02-04T12:47:58+00:00urn:sha1:b732166c5143f7ab1b657c8c0581ad8e8449ce84
This is simpler, doesn't need an auxiliary function of dubious value,
avouds an auxiliary variable and gets rid of a bunch of comments that
are hard to make sense of.
This doesn't bother to invalidate recp->shift since on error you should
not be reusing the RECP_CTX without reinitializing it.
ok jsing
Start cleaning up BN_div_reciprocal() a bit2025-02-04T05:09:53+00:00tb2025-02-04T05:09:53+00:00urn:sha1:09bef15f6dde7dfa51b7c2b40bd8dc186f44edf8
The fast path where no division is performed can be dealt with without
BN_CTX, so do that up front so there's no need to clean up before return.
Error check BN_CTX_get() on each use asd simplify the logic for optional
input parameters. KNF for an ugly comment.
ok jsing
bn_recp: Avoid complication for negative moduli2025-01-22T12:53:16+00:00tb2025-01-22T12:53:16+00:00urn:sha1:b247738e05b5336b6b755731d3686ac29e6cf54f
Instead of doing a weird dance, set the sign on N in BN_RECP_CTX_create().
Since we're not exposing a general purpose calculator API, we can simplify.
ok jsing
Rename BN_div_recp() into BN_div_reciprocal()2025-01-22T10:12:01+00:00tb2025-01-22T10:12:01+00:00urn:sha1:cf4e92c24aed14f7d79286679af5bc35b2578741
Requested by jsing
Split BN_mod_sqr_reciprocal() out of BN_mod_mul_reciprocal()2025-01-22T10:08:10+00:00tb2025-01-22T10:08:10+00:00urn:sha1:08809e17ad814f4314ef0a7cc09287483156803b
There's no need for BN_mod_mul_reciprocal() to have this complication.
The caller knows when x == y, so place the burden on the caller. This
simplifies both the caller side and the implementation in bn_recp.c.
ok jsing
BN_mod_mul_reciprocal: remove y == NULL complication2025-01-22T09:39:56+00:00tb2025-01-22T09:39:56+00:00urn:sha1:4beeaf6ba7000957e3b3dbf5ba0994c6c67f3b5e
No caller ever passes y == NULL, so remove the corresponding contortions
and unindent the relevant bits.
ok jsing
Move BN_RECP_CTX to the heap2025-01-21T15:44:22+00:00tb2025-01-21T15:44:22+00:00urn:sha1:797cf6b23360385bf34a89fce562aa5cb0a0e978
This introduces a BN_RECP_CTX_create() function that allocates and
populates the BN_RECP_CTX in a single call, without taking an unused
BN_CTX argument.
At the same time, make the N and Nr members BIGNUMs on the heap which
are allocated by BN_RECP_CTX_create() and freed by BN_RECP_CTX_free()
and remove the unnecessary flags argument.
Garbage collect the now unused BN_RECP_CTX_{new,init,set}().
ok jsing
Improve order of things in BN_RECP_CTX_set()2025-01-08T20:21:28+00:00tb2025-01-08T20:21:28+00:00urn:sha1:5eda5e9155502d3f84e351050563569c99460c35
+ some whitespace cosmetics