openbsd/src/lib/libcrypto/bn, branch libressl-v2.2.0A mirror of https://github.com/libressl/openbsd.git
https://git.lua4.win/openbsd/atom?h=libressl-v2.2.02015-06-11T15:55:28+00:00Avoid an infinite loop that can be triggered by parsing an ASN.12015-06-11T15:55:28+00:00jsing2015-06-11T15:55:28+00:00urn:sha1:095e36cd429c313ee8361e8877bc677116a2a2ce
ECParameters structure that has a specially malformed binary polynomial
field.
Issue reported by Joseph Barr-Pixton and fix based on OpenSSL.
Fixes CVE-2015-1788.
ok doug@ miod@
Add missing BN_CTX_end() calls.2015-04-29T00:11:12+00:00doug2015-04-29T00:11:12+00:00urn:sha1:7ddad7b77b00aa2097c75fdeb29c69c61e6b4c5b
After calling BN_CTX_start(), there must be a BN_CTX_end() before
returning. There were missing BN_CTX_end() calls in error paths. One diff
chunk was simply removing redundant code related to this.
ok deraadt@
Fix indentation that incorrectly implies a different control flow.2015-03-21T08:05:20+00:00doug2015-03-21T08:05:20+00:00urn:sha1:49c3a24c899173341c1bbdfe1fe50329dc016723
The actual control flow is intentional while the indenting is incorrect.
This is intended to be a cosmetic change.
Verified that each of these was part of a KNF commit that wasn't intending
to change behavior. Also, double checked against the history of changes in
OpenSSL and BoringSSL.
Addresses Coverity CIDs: 78842, 78859, 78863.
ok tedu@
Fix CVE-2014-3570: properly calculate the square of a BIGNUM value.2015-02-25T15:39:49+00:00bcook2015-02-25T15:39:49+00:00urn:sha1:f3031aa7bff24911a8cae9bdd7cdcd88d8554f42
See https://www.openssl.org/news/secadv_20150108.txt for a more detailed
discussion.
Original OpenSSL patch here:
https://github.com/openssl/openssl/commit/a7a44ba55cb4f884c6bc9ceac90072dea38e66d0
The regression test is modified a little for KNF.
ok miod@
If BN_rand() or BN_pseudo_rand() are called with a NULL rnd argument,2015-02-19T06:10:29+00:00jsing2015-02-19T06:10:29+00:00urn:sha1:62ebecd0e093eb1e8a47512de67da5c951069913
BN_bin2bn() will helpfully allocate a BN which is then leaked. Avoid this
by explicitly checking for NULL at the start of the bnrand() function.
Fixes Coverity ID 78831.
ok miod@
Potential NULL dereference in the error path; Coverity CID 217202015-02-14T15:13:24+00:00miod2015-02-14T15:13:24+00:00urn:sha1:ee551a6db5becbad6ba25358f2f3cba5e1237149
ok doug@ jsing@
Fix tests that got incorrectly inverted with the BN_CTX_get() return check2015-02-14T15:07:54+00:00jsing2015-02-14T15:07:54+00:00urn:sha1:cf070938980397dcaffa0ec800c735ddc1155af9
diff.
Spotted by miod@
Remove unnecessary include of assert.h2015-02-10T09:50:12+00:00miod2015-02-10T09:50:12+00:00urn:sha1:9a78b93a933764528a75722869255ee06e8eab6cBN_CTX_get() can fail - consistently check its return value.2015-02-09T15:49:22+00:00jsing2015-02-09T15:49:22+00:00urn:sha1:15dc63f9715f4f10924a705d6a4cc564afe2129e
There are currently cases where the return from each call is checked,
the return from only the last call is checked and cases where it is not
checked at all (including code in bn, ec and engine).
Checking the last return value is valid as once the function fails it will
continue to return NULL. However, in order to be consistent check each
call with the same idiom. This makes it easy to verify.
Note there are still a handful of cases that do not follow the idiom -
these will be handled separately.
ok beck@ doug@
Delete a lot of #if 0 code in libressl.2015-02-07T13:19:15+00:00doug2015-02-07T13:19:15+00:00urn:sha1:a58e958ffece1b48f50bc090357dee2cd5b1bc20
There are a few instances where #if 1 is removed but the code remains.
Based on the following OpenSSL commits. Some of the commits weren't
strictly deletions so they are going to be split up into separate commits.
6f91b017bbb7140f816721141ac156d1b828a6b3
3d47c1d331fdc7574d2275cda1a630ccdb624b08
dfb56425b68314b2b57e17c82c1df42e7a015132
c8fa2356a00cbaada8963f739e5570298311a060
f16a64d11f55c01f56baa62ebf1dec7f8fe718cb
9ccc00ef6ea65567622e40c49aca43f2c6d79cdb
02a938c953b3e1ced71d9a832de1618f907eb96d
75d0ebef2aef7a2c77b27575b8da898e22f3ccd5
d6fbb194095312f4722c81c9362dbd0de66cb656
6f1a93ad111c7dfe36a09a976c4c009079b19ea1
1a5adcfb5edfe23908b350f8757df405b0f5f71f
8de24b792743d11e1d5a0dcd336a49368750c577
a2b18e657ea1a932d125154f4e13ab2258796d90
8e964419603d2478dfb391c66e7ccb2dcc9776b4
32dfde107636ac9bc62a5b3233fe2a54dbc27008
input + ok jsing@, miod@, tedu@