openbsd/src/lib/libcrypto/bn, branch libressl-v3.2.3

Unindent a bit of code that performs a few too many checks to

2020-09-12T17:16:36+00:00

figure out whether top > 0 or top == 0.

Avoid an out-of-bounds access in BN_rand()

2020-09-12T15:24:39+00:00

If BN_rand() is called with top > 0 and bits == 1, it would allocate a buf[] of size 1 and set the top bit of buf[1]. Found in OpenSSL commit efee575ad464bfb60bf72dcb73f9b51768f4b1a1 while looking for something else. ok beck djm inoguchi

Change generating and checking of primes so that the error rate of

2019-08-25T19:24:00+00:00

not being prime depends on the intended use based on the size of the input. For larger primes this will result in more rounds of Miller-Rabin. The maximal error rate for primes with more than 1080 bits is lowered to 2^-128. Patch from Kurt Roeckx and Annie Yousar via OpenSSL commit feac7a1c Jul 25 18:55:16 2018 +0200, still under a free license. OK tb@.

make BN_CTX_end(NULL) a NOOP for compatibility with documented behaviour

2019-08-20T10:59:09+00:00

in OpenSSL 1.1.1 even though in general, letting random functions accept NULL is not advisable because it can hide programming errors; "yes please" tb@ "unfortunately I suspect you're right" jsing@ "oh well" deraadt@

Make BN_num_bits_word() constant time.

2019-06-17T17:11:48+00:00

Previously, this function would leak the most significant word of its argument due to branching and memory access pattern. This patch is enough to fix the use of BN_num_bits() on RSA prime factors in the library. The diff is a simplified and more readable (but perhaps less efficient) version of https://github.com/openssl/openssl/commit/972c87df by Andy Polyakov and David Benjamin (pre license change). Consult that commit message for details. Subsequent fixes to follow in the near future. Issue pointed out by David Schrammel and Samuel Weiser as part of a larger report. tests & ok inoguchi, ok jsing

Add range checks to varios ASN1_INTEGER functions to ensure the

2019-03-23T18:48:15+00:00

sizes used remain a positive integer. Should address issue 13799 from oss-fuzz ok tb@ jsing@

Fix BN_is_prime_* calls in libcrypto, the API returns -1 on error.

2019-01-20T01:56:59+00:00

From BoringSSL's commit 53409ee3d7595ed37da472bc73b010cd2c8a5ffd by David Benjamin. ok djm, jsing

Flip reversed test in bn_rand_interval().

2018-11-06T06:49:45+00:00

ok jsing

Introduce bn_rand_interval() that allows specifying an interval [a, b)

2018-11-05T23:52:47+00:00

from which a a BIGNUM is chosen uniformly at random. ok beck jsing

Use a size_t instead of an int for the byte count in BN_swap_ct().

2018-07-23T18:14:32+00:00

Since bignums use ints for the same purpose, this still uses an int internally after an overflow check. Suggested by and discussed with jsing. ok inoguchi, jsing