openbsd/src/lib/libcrypto/bn, branch libressl-v3.7.0

Update reference to table generation

2022-12-01T21:59:54+00:00

BN_one() can fail, check its return value.

2022-12-01T02:58:31+00:00

ok tb@

Rewrite bn_correct_top().

2022-11-30T03:08:39+00:00

bn_correct_top() is currently a macro and far more complex than it needs to be - rewrite it as a function. ok tb@

Fix return values bug in BN_ucmp().

2022-11-30T02:52:25+00:00

BN_ucmp() is supposed to return -1/0/1 on a < b, a == b and a > b, however it currently returns other negative and positive values when the top of a and b differ. Correct this. ok tb@

Mop up more BN_DEBUG related code.

2022-11-30T01:47:19+00:00

Make header guards of internal headers consistent

2022-11-26T17:23:18+00:00

Not all of them, only those that didn't leak into a public header... Yes.

bn_lcl.h wanted special treatment.

2022-11-26T16:11:36+00:00

Make internal header file names consistent

2022-11-26T16:08:57+00:00

Libcrypto currently has a mess of *_lcl.h, *_locl.h, and *_local.h names used for internal headers. Move all these headers we inherited from OpenSSL to *_local.h, reserving the name *_internal.h for our own code. Similarly, move dtls_locl.h and ssl_locl.h to dtls_local and ssl_local.h. constant_time_locl.h is moved to constant_time.h since it's special. Adjust all .c files in libcrypto, libssl and regress. The diff is mechanical with the exception of tls13_quic.c, where #include was fixed manually. discussed with jsing, no objection bcook

Remove BIGNUM consistency macros.

2022-11-26T13:56:33+00:00

Compiling with BN_DEBUG (and if you want to take it further, BN_DEBUG_RAND) supposedly adds consistency checks to the BN code. These are rarely if ever used and introduce a bunch of clutter in the code. Furthermore, there are hacks in place to undo things that the debugging code does. Remove all of this mess and instead rely on always enabled checks, more readable code and proper regress coverage to ensure correct behaviour. "Good riddance." tb@

Change bn_expand()/bn_wexpand() to indicate failure/success via 0/1.

2022-11-24T01:30:01+00:00

Currently bn_expand()/bn_wexpand() return a BIGNUM *, however none of the callers use this (and many already treat it as a true/false value). Change these functions to return 0 on failure and 1 on success, revising callers that test against NULL in the process. ok tb@