openbsd/src/lib/libcrypto/buffer/buffer.c, branch OPENBSD_6_8_BASE A mirror of https://github.com/libressl/openbsd.git https://git.lua4.win/openbsd/atom?h=OPENBSD_6_8_BASE 2017-05-02T03:59:45+00:00 use freezero() instead of memset/explicit_bzero + free. Substantially 2017-05-02T03:59:45+00:00 deraadt 2017-05-02T03:59:45+00:00 urn:sha1:5904cc0e04409fde39a97e6580535da34eeb4291 reduces conditional logic (-218, +82). MOD_EXP_CTIME_MIN_CACHE_LINE_WIDTH cache alignment calculation bn/bn_exp.c wasn'tt quite right. Two other tricky bits with ASN1_STRING_FLAG_NDEF and BN_FLG_STATIC_DATA where the condition cannot be collapsed completely. Passes regress. ok beck Simplify/clean up BUF_MEM_grow_clean(). 2017-04-09T15:06:20+00:00 jsing 2017-04-09T15:06:20+00:00 urn:sha1:61a0ac2c484da4166c337dbca9320e02b154e878 ok beck@ With recallocarray() BUF_MEM_grow() is essentially the same as 2017-04-09T15:03:54+00:00 jsing 2017-04-09T15:03:54+00:00 urn:sha1:c18a3c3d8006e8fe739bdbf116e38519ac9c22fe BUF_MEM_grow_clean() (the only difference is clearing on internal down sizing), so make it a wrapper. ok beck@ deraadt@ Convert BUF_MEM_grow() and BUF_MEM_grow_clean() to recallocarray(), 2017-03-16T13:29:56+00:00 jsing 2017-03-16T13:29:56+00:00 urn:sha1:66f094ce01d467fcd73cec6745bae67a846e549a ensuring that the buffer contents are zeroed on allocation and not leaked when resizing. It is worth noting that BUF_MEM_grow_clean() already did this manually by avoiding realloc(). ok beck@ inoguchi@ Use calloc() instead of malloc() followed by manually zeroing fields. 2017-03-16T13:15:06+00:00 jsing 2017-03-16T13:15:06+00:00 urn:sha1:b4dddea8c97475f1939497c762f59188eef7c9c3 ok beck@ inoguchi@ Send the function codes from the error functions to the bit bucket, 2017-01-29T17:49:23+00:00 beck 2017-01-29T17:49:23+00:00 urn:sha1:d1f47bd292f36094480caa49ada36b99a69c59b0 as was done earlier in libssl. Thanks inoguchi@ for noticing libssl had more reacharounds into this. ok jsing@ inoguchi@ Only import cryptlib.h in the four source files that actually need it. 2014-07-11T08:44:49+00:00 jsing 2014-07-11T08:44:49+00:00 urn:sha1:74e2c009c83ad374bd6acdcfc376a384e25ab007 Remove the openssl public includes from cryptlib.h and add a small number of includes into the source files that actually need them. While here, also sort/group/tidy the includes. ok beck@ miod@ Stop including standard headers via cryptlib.h - pull in the headers that 2014-07-10T13:58:23+00:00 jsing 2014-07-10T13:58:23+00:00 urn:sha1:c917c683bc93c68fbf4310ac181f7906e76b3c94 are needed in the source files that actually require them. ok beck@ miod@ Replace memset(a, 0, ...); free(a); by explicit_bzero(a, ...); free(a); in 2014-07-09T16:51:09+00:00 miod 2014-07-09T16:51:09+00:00 urn:sha1:a2694938f51e09289418ebb0c543b181fd4d929b fear a smartass-optimizing compiler decides memset is useless immediately before free(). ok jsing@ deraadt@ tedu@ tags as requested by miod and tedu 2014-06-12T15:49:31+00:00 deraadt 2014-06-12T15:49:31+00:00 urn:sha1:59f4f2c61d71e266d37dd2fc97615b3fd35b4721