openbsd/src/lib/libcrypto/buffer/buffer.c, branch libressl-v2.2.7 A mirror of https://github.com/libressl/openbsd.git https://git.lua4.win/openbsd/atom?h=libressl-v2.2.7 2015-08-02T21:54:23+00:00 This commit was manufactured by cvs2git to create branch 'OPENBSD_5_8'. 2015-08-02T21:54:23+00:00 cvs2svn admin@example.com 2015-08-02T21:54:23+00:00 urn:sha1:67fcb4ef3942fb3a0f1e18f8ebbe7464120d485a Only import cryptlib.h in the four source files that actually need it. 2014-07-11T08:44:49+00:00 jsing 2014-07-11T08:44:49+00:00 urn:sha1:74e2c009c83ad374bd6acdcfc376a384e25ab007 Remove the openssl public includes from cryptlib.h and add a small number of includes into the source files that actually need them. While here, also sort/group/tidy the includes. ok beck@ miod@ Stop including standard headers via cryptlib.h - pull in the headers that 2014-07-10T13:58:23+00:00 jsing 2014-07-10T13:58:23+00:00 urn:sha1:c917c683bc93c68fbf4310ac181f7906e76b3c94 are needed in the source files that actually require them. ok beck@ miod@ Replace memset(a, 0, ...); free(a); by explicit_bzero(a, ...); free(a); in 2014-07-09T16:51:09+00:00 miod 2014-07-09T16:51:09+00:00 urn:sha1:a2694938f51e09289418ebb0c543b181fd4d929b fear a smartass-optimizing compiler decides memset is useless immediately before free(). ok jsing@ deraadt@ tedu@ tags as requested by miod and tedu 2014-06-12T15:49:31+00:00 deraadt 2014-06-12T15:49:31+00:00 urn:sha1:59f4f2c61d71e266d37dd2fc97615b3fd35b4721 realloc with NULL is same as malloc 2014-06-01T22:14:53+00:00 deraadt 2014-06-01T22:14:53+00:00 urn:sha1:d58d5e2b67c3b3655aa59a382c87a1890fd4dfcb ok guenther Commit this before the head-scratching leads to premature baldness: 2014-06-01T15:10:53+00:00 deraadt 2014-06-01T15:10:53+00:00 urn:sha1:717067e4cee6765e5c81f8fe6701a5d4741d6e76 memset(a->data, 0, (unsigned int)a->max); but the decl is: size_t max; size_t could be larger than int, especially in some of the systems OpenSSL purports to support. How do _intentionally truncating_ casts like enter into a codebase? Lack of understanding of C, at a minimum. Generally the objects are small, but this code is _intentionally unready_ for large objects. ok miod More KNF. 2014-04-26T13:07:16+00:00 jsing 2014-04-26T13:07:16+00:00 urn:sha1:a1c73b72875dcb25545f111b3779cf0f0ebf9c88 remove OPENSSL_realloc_clean usage here - replace with intrinsics to make 2014-04-17T16:30:59+00:00 beck 2014-04-17T16:30:59+00:00 urn:sha1:29d25d7d30e1d53fae58f4e2229c9ef758b54ca5 it obvious what should happen. ok tedu@ Initial KNF. 2014-04-17T13:58:24+00:00 jsing 2014-04-17T13:58:24+00:00 urn:sha1:83f887261aa740d406437b134c1850b51f98ba53