openbsd/src/lib/libcrypto/cmac, branch libressl-v3.4.1 A mirror of https://github.com/libressl/openbsd.git https://git.lua4.win/openbsd/atom?h=libressl-v3.4.1 2015-09-10T15:56:26+00:00 Correct spelling of OPENSSL_cleanse. 2015-09-10T15:56:26+00:00 jsing 2015-09-10T15:56:26+00:00 urn:sha1:647569a51c1530d10e75e272f0982682f696caa7 ok miod@ if (x) FOO_free(x) -> FOO_free(x). 2014-07-12T16:03:37+00:00 miod 2014-07-12T16:03:37+00:00 urn:sha1:068bf464df6ef084067943863d776f59762bfaf0 Improves readability, keeps the code smaller so that it is warmer in your cache. review & ok deraadt@ Principle of least surprise: make CMAC_CTX_free(), OCSP_REQ_CTX_free() and 2014-07-12T14:58:32+00:00 miod 2014-07-12T14:58:32+00:00 urn:sha1:19a19b8eff7c4c610f87ca07a02612af9017c9d9 X509_STORE_CTX_free() accept NULL pointers as input without dereferencing them, like all the other well-behaved *_CTX_free() functions do. Only import cryptlib.h in the four source files that actually need it. 2014-07-11T08:44:49+00:00 jsing 2014-07-11T08:44:49+00:00 urn:sha1:74e2c009c83ad374bd6acdcfc376a384e25ab007 Remove the openssl public includes from cryptlib.h and add a small number of includes into the source files that actually need them. While here, also sort/group/tidy the includes. ok beck@ miod@ Stop including standard headers via cryptlib.h - pull in the headers that 2014-07-10T13:58:23+00:00 jsing 2014-07-10T13:58:23+00:00 urn:sha1:c917c683bc93c68fbf4310ac181f7906e76b3c94 are needed in the source files that actually require them. ok beck@ miod@ More KNF. 2014-06-21T13:42:14+00:00 jsing 2014-06-21T13:42:14+00:00 urn:sha1:415c0aa250bb30e28ba0c8a4a5b012fff4e5bf12 KNF 2014-06-21T12:07:02+00:00 miod 2014-06-21T12:07:02+00:00 urn:sha1:66103ef8158b07886dde011479a7955a3e261878 tags as requested by miod and tedu 2014-06-12T15:49:31+00:00 deraadt 2014-06-12T15:49:31+00:00 urn:sha1:59f4f2c61d71e266d37dd2fc97615b3fd35b4721 typo in comment 2014-04-27T20:38:39+00:00 miod 2014-04-27T20:38:39+00:00 urn:sha1:f087dedc31f3ef023f5b4f1ee451f5de75464c0c Use C99 initializers for the various FOO_METHOD structs. More readable, and 2014-04-27T20:26:49+00:00 miod 2014-04-27T20:26:49+00:00 urn:sha1:b5544d0885b7b6ceebce880a188724826a8fc5e9 avoid unreadable/unmaintainable constructs like that: const EVP_PKEY_ASN1_METHOD cmac_asn1_meth = { EVP_PKEY_CMAC, EVP_PKEY_CMAC, 0, "CMAC", "OpenSSL CMAC method", 0,0,0,0, 0,0,0, cmac_size, 0, 0,0,0,0,0,0,0, cmac_key_free, 0, 0,0 }; ok matthew@ deraadt@