openbsd/src/lib/libcrypto/cms/cms_err.c, branch OPENBSD_7_9_BASEA mirror of https://github.com/libressl/openbsd.git
https://git.lua4.win/openbsd/atom?h=OPENBSD_7_9_BASE2024-06-24T06:43:23+00:00libcrypto: constify most error string tables2024-06-24T06:43:23+00:00tb2024-06-24T06:43:23+00:00urn:sha1:c9802a5afe29675d69b605ce906d34fd89c024ac
These constitute the bulk of the remaining global mutable state in
libcrypto. This commit moves most of them into data.rel.ro, leaving
out ERR_str_{functs,libraries,reasons} (which require a slightly
different approach) and SYS_str_reasons which is populated on startup.
The main observation is that if ERR_load_strings() is called with a 0 lib
argument, the ERR_STRING_DATA argument is not actually modified. We could
use this fact to cast away const on the caller side and be done with it.
We can make this cleaner by adding a helper ERR_load_const_strings() which
explicitly avoids the assignment to str->error overriding the error code
already set in the table.
In order for this to work, we need to sprinkle some const in err/err.c.
CMS called ERR_load_strings() with non-0 lib argument, but this didn't
actually modify the error data since it ored in the value already stored
in the table.
Annoyingly, we need to cast const away once, namely in the call to
lh_insert() in int_err_set_item(). Fixing this would require changing
the public API and is going to be tricky since it requires that the
LHASH_DOALL_FN_* types adjust.
ok jsing
Hide symbols in cms, comp, conf, and buffer2023-07-08T08:26:26+00:00beck2023-07-08T08:26:26+00:00urn:sha1:cf9b236f0893157746f8b944e4f6cc8d8a6aca26
ok jsing@
Remove mkerr.pl remnants from LibreSSL2022-07-12T14:42:50+00:00kn2022-07-12T14:42:50+00:00urn:sha1:89e42d5857196a8071fbafb5565388d0e20ec32b
This script is not used at all and files are edited by hand instead.
Thus remove misleading comments incl. the obsolete script/config.
Feedback OK jsing tb
Remove remaining error *_str_functs[]2020-06-05T16:51:12+00:00jsing2020-06-05T16:51:12+00:00urn:sha1:6aa0c4f1ec702bb2c820322709abd9c1767842fa
A number of years ago we dropped the concept of having function names in
errors, since it is not that useful and very quickly gets out of sync when
refactoring. It would seem that some new ones got imported and some missed
the last clean up.
ok tb@ beck@ "kill it with fire"
Fix loading of CMS error strings.2019-08-11T14:18:38+00:00jsing2019-08-11T14:18:38+00:00urn:sha1:0946db36026818b2168f7bdab9764edc5c1d9a32More style(9), whitespace and readability fixes.2019-08-10T18:15:52+00:00jsing2019-08-10T18:15:52+00:00urn:sha1:cd017df13ee5f5ba7baa4ffe853ae05106ef3cac
Files are identical once whitespace and newlines are removed.
First pass at style(9).2019-08-10T16:42:20+00:00jsing2019-08-10T16:42:20+00:00urn:sha1:75125ce1cf513471883fff50db4a4638526bd785
Whitespace only and no change according to diff -w.
Include cms.h instead of cmserr.h.2019-08-10T16:38:47+00:00jsing2019-08-10T16:38:47+00:00urn:sha1:7f518dee1343fdbc89606b441a3351f336e98342Add $OpenBSD$ tags.2019-08-10T16:03:54+00:00jsing2019-08-10T16:03:54+00:00urn:sha1:5f53ff9a2d756f84baa35744a9e195a2d5294470Work towards supporting Cryptographic Message Syntax (CMS) in libcrypto.2019-08-10T15:55:20+00:00jsing2019-08-10T15:55:20+00:00urn:sha1:4df8f2a71206786b2b61d7295a263df61028b550
Cryptographic Message Syntax (CMS) is a standard for cryptographically
protecting messages, as defined in RFC 5652. It is derived from PKCS #7
version 1.5 and utilises various ASN.1 structures, making it complex and
fairly heavyweight. Various protocols - including RPKI (RFC 6480) - have
been built on top of it, which means it is necessary to support CMS, in
order to support RPKI.
This imports around 6,000 lines of code from OpenSSL 1.1.1, which is still
under the original OpenSSL license. Further work will occur in tree.
Requested by and discussed with many.
ok deraadt@ tb@