openbsd/src/lib/libcrypto/cms, branch OPENBSD_7_3_BASE

pk7_cb() and cms_cb()

2023-03-12T17:29:02+00:00

Add and fix FALLTHROUGH statement. I was confused for way too long since I hadn't noticed that this case fell through to the next. Also add and move some empty lines in the cms_cb() to make this resemble KNF more.

Make header guards of internal headers consistent

2022-11-26T17:23:18+00:00

Not all of them, only those that didn't leak into a public header... Yes.

Make internal header file names consistent

2022-11-26T16:08:57+00:00

Libcrypto currently has a mess of *_lcl.h, *_locl.h, and *_local.h names used for internal headers. Move all these headers we inherited from OpenSSL to *_local.h, reserving the name *_internal.h for our own code. Similarly, move dtls_locl.h and ssl_locl.h to dtls_local and ssl_local.h. constant_time_locl.h is moved to constant_time.h since it's special. Adjust all .c files in libcrypto, libssl and regress. The diff is mechanical with the exception of tls13_quic.c, where #include was fixed manually. discussed with jsing, no objection bcook

Plug memory leak in CMS_add_simple_smimecap() in the unlikely event that

2022-08-28T18:27:47+00:00

ASN1_INTEGER_set() fails. ok jsing

Remove mkerr.pl remnants from LibreSSL

2022-07-12T14:42:50+00:00

This script is not used at all and files are edited by hand instead. Thus remove misleading comments incl. the obsolete script/config. Feedback OK jsing tb

Add check for EVP_CIPHER_CTX_set_key_length return value

2022-01-20T10:58:35+00:00

It returns 1 on success and 0 for failure, never negative value. ok jsing@ millert@ tb@

Check return value from EVP_CIPHER_CTX_new in cms_pwri.c

2022-01-19T13:47:44+00:00

CID 345137 ok jsing@ tb@

Garbage collect the app_items field of ASN1_ADB

2022-01-14T08:16:13+00:00

This is unused and was removed in OpenSSL 5b70372d when it was replaced with an ASN.1 ADB callback (which we don't support). ok inoguchi jsing

Move the now internal X.509-related structs into x509_lcl.h.

2021-11-01T20:53:08+00:00

Garbage collect the now unused LIBRESSL_CRYPTO_INTERNAL and LIBRESSL_OPAQUE_X509. Include "x509_lcl.h" where needed and fix a couple of unnecessary reacharounds. ok jsing

Fix leak in cms_RecipientInfo_kekri_decrypt()

2021-09-08T14:33:02+00:00

Free ec->key before reassigning it. From OpenSSL 1.1.1, 58e1e397 ok inoguchi