openbsd/src/lib/libcrypto/conf/conf_mod.c, branch OPENBSD_6_8_BASE A mirror of https://github.com/libressl/openbsd.git https://git.lua4.win/openbsd/atom?h=OPENBSD_6_8_BASE 2017-01-29T17:49:23+00:00 Send the function codes from the error functions to the bit bucket, 2017-01-29T17:49:23+00:00 beck 2017-01-29T17:49:23+00:00 urn:sha1:d1f47bd292f36094480caa49ada36b99a69c59b0 as was done earlier in libssl. Thanks inoguchi@ for noticing libssl had more reacharounds into this. ok jsing@ inoguchi@ Remove all getenv() calls, especially those wrapped by issetugid(). 2015-04-11T16:03:21+00:00 deraadt 2015-04-11T16:03:21+00:00 urn:sha1:b6e092d1e41107edc3265fcda97c497aa21950e1 getenv()'s wrapped by issetugid() are safe, but issetugid() is correct difficult to impliment on many operating systems. By accident, a grand experiment was run over the last year, where issetugid() returned 1 (the safe value) on a few operating systems. Noone noticed & complained that certain environment variables were not working....... ok doug beck jsing, discussion with others Kill a bunch more BUF_strdup's - these are converted to have a check for 2014-07-22T02:21:20+00:00 beck 2014-07-22T02:21:20+00:00 urn:sha1:de26b5621b74df2934238e0cedd549c31c9c6a32 NULL before an intrinsic strdup. ok miod@ The bell tolls for BUF_strdup - Start the migration to using 2014-07-13T16:03:10+00:00 beck 2014-07-13T16:03:10+00:00 urn:sha1:c7e9c2c6576cd5406680f9b69aff2038ba63b0dc intrinsics. This is the easy ones, a few left to check one at a time. ok miod@ deraadt@ Only import cryptlib.h in the four source files that actually need it. 2014-07-11T08:44:49+00:00 jsing 2014-07-11T08:44:49+00:00 urn:sha1:74e2c009c83ad374bd6acdcfc376a384e25ab007 Remove the openssl public includes from cryptlib.h and add a small number of includes into the source files that actually need them. While here, also sort/group/tidy the includes. ok beck@ miod@ Stop including standard headers via cryptlib.h - pull in the headers that 2014-07-10T13:58:23+00:00 jsing 2014-07-10T13:58:23+00:00 urn:sha1:c917c683bc93c68fbf4310ac181f7906e76b3c94 are needed in the source files that actually require them. ok beck@ miod@ Since this is a library, place issetugid() before every getenv() 2014-06-23T22:19:02+00:00 deraadt 2014-06-23T22:19:02+00:00 urn:sha1:5ba01919626638d95dda5319c6aa4e793eedfd20 ok miod tags as requested by miod and tedu 2014-06-12T15:49:31+00:00 deraadt 2014-06-12T15:49:31+00:00 urn:sha1:59f4f2c61d71e266d37dd2fc97615b3fd35b4721 no need for null check before free. from Brendan MacDonell 2014-05-30T02:52:11+00:00 tedu 2014-05-30T02:52:11+00:00 urn:sha1:c442171f7692d3610a7aa5a08593cabf7253c5af Replace all use of ERR_add_error_data with ERR_asprintf_error_data. 2014-04-26T18:56:38+00:00 beck 2014-04-26T18:56:38+00:00 urn:sha1:e7dbd7a1e2ad3e12dafa2919bc8603d60416ea4d This avoids a lot of ugly gymnastics to do snprintfs before sending the bag of strings to ERR, and eliminates at least one place in dso_dlfctn.c where it was being called with the incorrect number of arguments and using random things off the stack as addresses of strings. ok krw@, jsing@