openbsd/src/lib/libcrypto/ct/ct_err.c, branch OPENBSD_7_9A mirror of https://github.com/libressl/openbsd.git
https://git.lua4.win/openbsd/atom?h=OPENBSD_7_92024-06-24T06:43:23+00:00libcrypto: constify most error string tables2024-06-24T06:43:23+00:00tb2024-06-24T06:43:23+00:00urn:sha1:c9802a5afe29675d69b605ce906d34fd89c024ac
These constitute the bulk of the remaining global mutable state in
libcrypto. This commit moves most of them into data.rel.ro, leaving
out ERR_str_{functs,libraries,reasons} (which require a slightly
different approach) and SYS_str_reasons which is populated on startup.
The main observation is that if ERR_load_strings() is called with a 0 lib
argument, the ERR_STRING_DATA argument is not actually modified. We could
use this fact to cast away const on the caller side and be done with it.
We can make this cleaner by adding a helper ERR_load_const_strings() which
explicitly avoids the assignment to str->error overriding the error code
already set in the table.
In order for this to work, we need to sprinkle some const in err/err.c.
CMS called ERR_load_strings() with non-0 lib argument, but this didn't
actually modify the error data since it ored in the value already stored
in the table.
Annoyingly, we need to cast const away once, namely in the call to
lh_insert() in int_err_set_item(). Fixing this would require changing
the public API and is going to be tricky since it requires that the
LHASH_DOALL_FN_* types adjust.
ok jsing
Remove mkerr.pl remnants from LibreSSL2022-07-12T14:42:50+00:00kn2022-07-12T14:42:50+00:00urn:sha1:89e42d5857196a8071fbafb5565388d0e20ec32b
This script is not used at all and files are edited by hand instead.
Thus remove misleading comments incl. the obsolete script/config.
Feedback OK jsing tb
Remove openssl/cterr.h and inline it in openssl/ct.h2022-05-08T20:59:32+00:00tb2022-05-08T20:59:32+00:00urn:sha1:8ce75307b6eeae36eef3a3458c5163787c3d2fb7
ok jsing
Revert license stubs to full licenses in the remaining files.2021-12-18T16:50:40+00:00tb2021-12-18T16:50:40+00:00urn:sha1:3596705559bac06b4d47e94fecd56f3676b13e40Add RCS markers2021-12-05T09:37:46+00:00tb2021-12-05T09:37:46+00:00urn:sha1:5ff9dee7ebfd679cd80b880b7d2c7fc874b093bdMake these files compile - not hooked up to build yet.2021-11-20T01:10:49+00:00beck2021-11-20T01:10:49+00:00urn:sha1:b7cded0ac3a92a8240de5424e37e204c1f237e33
ok jsing@ tb@
Mechanical KNF in preparation for changing2021-10-28T11:55:43+00:00beck2021-10-28T11:55:43+00:00urn:sha1:92391c1802f1d1cd2771f7e48fb0a19e975a26f5Import Certificate Transparency verbatim from OpenSSL 1.1.12021-10-28T11:21:03+00:00beck2021-10-28T11:21:03+00:00urn:sha1:3d4365350a2581e12035198600c42bdbbf87c38a
This is not yet hooked up and will not compile. Follow on commits
will KNF and then make it build.
ok jsing@ tb@