openbsd/src/lib/libcrypto/des, branch libressl-v2.1.2 A mirror of https://github.com/libressl/openbsd.git https://git.lua4.win/openbsd/atom?h=libressl-v2.1.2 2014-10-28T07:35:59+00:00 deregister; no binary change 2014-10-28T07:35:59+00:00 jsg 2014-10-28T07:35:59+00:00 urn:sha1:0505bd63c15c82aead21cde52afbf6c41421d140 ok jsing@ miod@ Use arc4random_buf() instead of RAND_bytes() or RAND_pseudo_bytes(). 2014-10-22T13:02:04+00:00 jsing 2014-10-22T13:02:04+00:00 urn:sha1:fa457604779ff38b511fdfdae3c6a78664281c22 arc4random_buf() is guaranteed to always succeed - it is worth noting that a number of the replaced function calls were already missing return value checks. ok deraadt@ Remove useless comments in DES_is_weak_key(). Do we really care that this 2014-10-12T20:48:58+00:00 miod 2014-10-12T20:48:58+00:00 urn:sha1:7c6875aa96e2c3ef7b8f7cca8a49601fbca7b5b5 function was found broken in 1993, and later on in 1997? replace more ROTATE macros with plain-old C code. 2014-08-18T19:15:34+00:00 bcook 2014-08-18T19:15:34+00:00 urn:sha1:14d7e512f02ca19b08bb321eadc6d6490ae21f11 Let the compiler optimize these. Even older versions of gcc generate equal or better quality code than the inline asm. ok miod@ In DES_random_key(), force the generated key to the odd parity before checking 2014-07-22T18:09:20+00:00 miod 2014-07-22T18:09:20+00:00 urn:sha1:ae3ddac8a2c0327ef4ee78740df590f055b72097 it is not one of the weak and semi-weak keys. Even though the probability of generating a weak key with incorrect parity is abysmally small, there is no reason to be correct (although, if you're in a need for fresh DES keys nowadays, you should seriously consider switching to a stronger symmetric cipher algorithm). ok beck@ Only import cryptlib.h in the four source files that actually need it. 2014-07-11T08:44:49+00:00 jsing 2014-07-11T08:44:49+00:00 urn:sha1:74e2c009c83ad374bd6acdcfc376a384e25ab007 Remove the openssl public includes from cryptlib.h and add a small number of includes into the source files that actually need them. While here, also sort/group/tidy the includes. ok beck@ miod@ Explicitly include <openssl/opensslconf.h> in every file that references 2014-07-10T22:45:58+00:00 jsing 2014-07-10T22:45:58+00:00 urn:sha1:62348213609ef233110561d1a6ed67ad66df1c7e an OPENSSL_NO_* define. This avoids relying on something else pulling it in for us, plus it fixes several cases where the #ifndef OPENSSL_NO_XYZ is never going to do anything, since OPENSSL_NO_XYZ will never defined, due to the fact that opensslconf.h has not been included. This also includes some miscellaneous sorting/tidying of headers. Remove leading underscore from _BYTE_ORDER and _{LITTLE,BIG}_ENDIAN, to be 2014-07-09T16:06:14+00:00 miod 2014-07-09T16:06:14+00:00 urn:sha1:fe535df650692f5223eb9afe4a8c46e41351c604 more friendly to systems where the underscore flavours may be defined as empty. Found the hard way be bcook@; joint brainstrom with bcook beck and guenther remove unused, private version strings except SSL_version_str 2014-07-09T11:10:51+00:00 bcook 2014-07-09T11:10:51+00:00 urn:sha1:0563b5d49da5a96960925938b3e4f3152e6f5c92 Also remove unused des_ver.h, which exports some of these strings, but is not installed. ok miod@ tedu@ Remove undocumented _des_crypt() interface and its companion header file, 2014-07-08T16:07:37+00:00 miod 2014-07-08T16:07:37+00:00 urn:sha1:7fe3a8bc98ac25e33c1da163ac4e6f5dc7603a30 which had never been installed, so it's unlikely something ever used this in the last 15~20 years. ok deraadt@ jsing@ beck@