openbsd/src/lib/libcrypto/dh/dh_ameth.c, branch OPENBSD_7_9A mirror of https://github.com/libressl/openbsd.git
https://git.lua4.win/openbsd/atom?h=OPENBSD_7_92025-05-10T05:54:39+00:00Use err_local.h rather than err.h in most places2025-05-10T05:54:39+00:00tb2025-05-10T05:54:39+00:00urn:sha1:41e8f99dd1625a9f0c80ce9d4383e95b18e85709
ok jsing
dh_ameth: explcitly -> explicitly2025-01-17T05:04:25+00:00tb2025-01-17T05:04:25+00:00urn:sha1:cd1f21f8cbb9151769acbc7fd34da681a4d97a73Remove the pkey_{,public_,param_}check() handlers2024-08-29T16:58:19+00:00tb2024-08-29T16:58:19+00:00urn:sha1:c8099c070f0c547b73edced83591dbd871254307
This disables the EVP_PKEY_*check() API and makes it fail (more precisely
indicate lack of support) on all key types.
This is an intermediate step to full removal.
Removal is ok beck jsing
Replace .pkey_base_id with a .base_method pointer2024-01-04T17:01:26+00:00tb2024-01-04T17:01:26+00:00urn:sha1:9f1cd2582409ac5778c5a0e28dfb77f18d122c98
Every EVP_PKEY_ASN1_METHOD is either an ASN.1 method or an alias.
As such it resolves to an underlying ASN.1 method (in one step).
This information can be stored in a base_method pointer in allusion
to the pkey_base_id, which is the name for the nid (aka pkey_id aka
type) of the underlying method.
For an ASN.1 method, the base method is itself, so the base method
is set as a pointer to itself. For an alias it is of course a pointer
to the underlying method. Then obviously ameth->pkey_base_id is the
same as ameth->base_method->pkey_id, so rework all ASN.1 methods to
follow that.
ok jsing
Drop silly int_ prefix from _free() and _size()2023-08-12T07:59:48+00:00tb2023-08-12T07:59:48+00:00urn:sha1:156606251785f22da3265415907d576d76db2ff6Free {priv,pub}_key before assigning to it2023-08-12T07:50:47+00:00tb2023-08-12T07:50:47+00:00urn:sha1:75d00cb38a793e674ec61e79cfad30c174e5a93c
While it isn't the case for the default implementations, custom DH and DSA
methods could conceivably populate private and public keys, which in turn
would result in leaks in the pub/priv decode methods.
ok jsing
Simplify and unify missing_parameters() for DH and DSA2023-08-12T07:43:48+00:00tb2023-08-12T07:43:48+00:00urn:sha1:ca959b67a4d1cc2713bf6ef88288116f17fcc8cc
ok jsing
Improve variable names in {dh,dsa}_{pub,priv}_{de,en}code()2023-08-11T13:57:24+00:00tb2023-08-11T13:57:24+00:00urn:sha1:1d23790aedecd16063a7b5e8eb1b0f7009f81d22
Use aint for the ASN1_INTEGER holding the key and astr for the ASN1_STRING
holding the parameters. This frees up key and params for their DER encoded
versions, matching the naming we use elsewhere much more closely.
ok jsing
Use params{,_len} in {dh,dsa}_params_{en,de}code()2023-08-11T13:53:45+00:00tb2023-08-11T13:53:45+00:00urn:sha1:e392da2d02a86f657177c5d0b765fb6ffacc45b1Align dh and dsa decoding functions with encoding2023-08-11T11:32:19+00:00tb2023-08-11T11:32:19+00:00urn:sha1:30b9bf3476045dde6388822dd4c4f5ef7377d658
This adds some missing error checks and fixes and unifies error codes
which were (as usual) all over the place or just plain nonsense. Use
an auxiliary variable for d2i invocations even though it is not really
needed here.
ok jsing