openbsd/src/lib/libcrypto/dh/dh_key.c, branch OPENBSD_7_9

Use err_local.h rather than err.h in most places

2025-05-10T05:54:39+00:00

ok jsing

Make the DH_METHOD static const

2024-05-09T20:43:36+00:00

Move public API and DH_METHOD to the bottom of the file

2024-05-09T20:40:42+00:00

no functional change

Make the bn_rand_interval() API a bit more ergonomic

2023-08-03T18:53:56+00:00

Provide bn_rand_in_range() which is a slightly tweaked version of what was previously called bn_rand_range(). The way bn_rand_range() is called in libcrypto, the lower bound is always expressible as a word. In fact, most of the time it is 1, the DH code uses a 2, the MR tests in BPSW use 3 and an exceptinally high number appears in the Tonelli-Shanks implementation where we use 32. Converting these lower bounds to BIGNUMs on the call site is annoying so let bn_rand_interval() do that internally and route that through bn_rand_in_range(). This way we can avoid using BN_sub_word(). Adjust the bn_isqrt() test to use bn_rand_in_range() since that's the only caller that uses actual BIGNUMs as lower bounds. ok jsing

Hide symbols in dh

2023-07-08T15:29:04+00:00

ok tb@

Make internal header file names consistent

2022-11-26T16:08:57+00:00

Libcrypto currently has a mess of *_lcl.h, *_locl.h, and *_local.h names used for internal headers. Move all these headers we inherited from OpenSSL to *_local.h, reserving the name *_internal.h for our own code. Similarly, move dtls_locl.h and ssl_locl.h to dtls_local and ssl_local.h. constant_time_locl.h is moved to constant_time.h since it's special. Adjust all .c files in libcrypto, libssl and regress. The diff is mechanical with the exception of tls13_quic.c, where #include was fixed manually. discussed with jsing, no objection bcook

Add an essentially empty dh_local.h and include it in the files where

2022-01-07T09:27:13+00:00

it will be needed in the upcoming bump. discussed with jsing

Missing initialization for pub_key. CID 184303.

2018-11-12T17:39:17+00:00

ok bcook

Initialize priv_key and pub_key on first use instead of at the top.

2018-11-09T23:49:18+00:00

While there, eliminate a flag that was only used once. ok beck jsing mestre

unrevert the use of bn_rand_interval().

2018-11-06T07:02:33+00:00

ok beck jsing